Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jun 10, 2024

PR-Codex overview

The focus of this PR is to add a potential error message for EIP155 failure and update chain definitions for testing.

Detailed summary

  • Added potential error message for EIP155 failure in is-eip155-enforced.ts
  • Updated chain definition import from optimism to base in is-eip155-enforced.test.ts
  • Replaced sendAndConfirmTransaction with sendTransaction in smart-wallet-zksync.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 10:25pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 80f9296

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite Graphite

@gregfromstl gregfromstl marked this pull request as ready for review June 10, 2024 21:44
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 10, 2024

CodSpeed Performance Report

Merging #3263 will not alter performance

Comparing 06-10-fix_tests (80f9296) with main (73af67a)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.29 KB (0%) 806 ms (0%) 2.3 s (+28.44% 🔺) 3.1 s
thirdweb (cjs) 89.94 KB (0%) 1.8 s (0%) 6.9 s (-4.21% 🔽) 8.7 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 396 ms (+139.01% 🔺) 491 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 272 ms (+34.82% 🔺) 282 ms
thirdweb/react (minimal + tree-shaking) 15.75 KB (0%) 315 ms (0%) 621 ms (+10.5% 🔺) 936 ms

@codecov
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.32%. Comparing base (ce45d4f) to head (80f9296).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3263      +/-   ##
==========================================
- Coverage   63.33%   63.32%   -0.01%     
==========================================
  Files         833      833              
  Lines       63393    63394       +1     
  Branches     3425     3423       -2     
==========================================
- Hits        40147    40145       -2     
- Misses      22571    22574       +3     
  Partials      675      675              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.60% <ø> (ø) Carriedforward from ce45d4f
packages 62.85% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...s/thirdweb/src/utils/any-evm/is-eip155-enforced.ts 94.56% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

github-actions bot and others added 2 commits June 10, 2024 15:23
This PR was automatically created by a GitHub Action. It updates the chains package with the latest changes from the database.
@gregfromstl gregfromstl added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit f2004b5 Jun 10, 2024
@gregfromstl gregfromstl deleted the 06-10-fix_tests branch June 10, 2024 22:39
@jnsdls jnsdls mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants