Skip to content

Fix tests #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix tests #3263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13adeae
chore(chains): update chains (#3257)
github-actions[bot] Jun 10, 2024
80f9296
Fix tests
gregfromstl Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brown-rats-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Add potential error message for eip155 failure
4 changes: 2 additions & 2 deletions packages/thirdweb/src/utils/any-evm/is-eip155-enforced.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { describe, expect, it } from "vitest";
import { ANVIL_CHAIN } from "../../../test/src/chains.js";
import { TEST_CLIENT } from "../../../test/src/test-clients.js";
import { optimism } from "../../chains/chain-definitions/optimism.js";
import { base } from "../../chains/chain-definitions/base.js";
import { isEIP155Enforced } from "./is-eip155-enforced.js";

// skip this test suite if there is no secret key available to test with
Expand All @@ -11,7 +11,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("isEIP155Enforced", () => {
// Call the isEIP155Enforced function with a chain that enforces EIP-155
const result = await isEIP155Enforced({
// optimism enforce eip155
chain: optimism,
chain: base,
client: TEST_CLIENT,
});

Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/utils/any-evm/is-eip155-enforced.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ const ERROR_SUBSTRINGS = [
"chainid no support",
"chainid (0)",
"chainid(0)",
"invalid sender",
];

function matchError(error: string): boolean {
Expand Down
4 changes: 2 additions & 2 deletions packages/thirdweb/src/wallets/smart/smart-wallet-zksync.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ANVIL_PKEY_C } from "../../../test/src/test-wallets.js";
import { zkSyncSepolia } from "../../chains/chain-definitions/zksync-sepolia.js";
import { getContract } from "../../contract/contract.js";
import { claimTo } from "../../extensions/erc1155/drops/write/claimTo.js";
import { sendAndConfirmTransaction } from "../../transaction/actions/send-and-confirm-transaction.js";
import { sendTransaction } from "../../transaction/actions/send-transaction.js";
import { smartWallet } from "../create-wallet.js";
import type { Account, Wallet } from "../interfaces/wallet.js";
import { privateKeyToAccount } from "../private-key.js";
Expand Down Expand Up @@ -47,7 +47,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
});

it("should send a transactions", async () => {
const tx = await sendAndConfirmTransaction({
const tx = await sendTransaction({
transaction: claimTo({
contract,
quantity: 1n,
Expand Down