Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jun 25, 2024

  1. Created a new .env.example file specifying the NEXT_PUBLIC_ROOT_DOMAIN variable.
  2. Updated .gitignore to include .env*.local instead of .env*.
  3. Modified the Layout component in [ecosystem]/layout.tsx to accept children and params properties and display the ecosystem and children elements.
  4. Updated the Page component in [ecosystem]/page.tsx to return a simple div with the text Page.
  5. Added a new middleware.ts file to handle dynamic routing based on the request host, matching all paths except for specific routes (e.g., /api, /_next, /_static). Rewrites the URL to point to either the root application or the appropriate ecosystem dynamic route.


PR-Codex overview

This PR introduces ecosystem-related features and UI improvements, adds Erc20 and Erc721 token types, enhances client-side and server-side logic, updates dependencies, and refactors UI components.

Detailed summary

  • Added Ecosystem type and related functions
  • Updated Biome config
  • Implemented revalidate function
  • Added Erc20Token and Erc721Token types
  • Introduced Loading component
  • Implemented cn utility function
  • Added Card and Skeleton components
  • Updated client configuration
  • Added NotFound page
  • Updated components.json
  • Added Page component
  • Updated next.config.mjs
  • Added getEcosystemInfo function
  • Updated tsconfig.json
  • Updated tailwind.config.ts
  • Added Providers component
  • Updated layout components
  • Added Label component
  • Updated package.json
  • Added Input component
  • Added getChains function

The following files were skipped due to too many changes: apps/wallet-ui/src/lib/chains.ts, apps/wallet-ui/src/components/ui/sonner.tsx, apps/wallet-ui/src/components/ConnectButton.tsx, apps/wallet-ui/src/app/[ecosystem]/login/page.tsx, apps/wallet-ui/src/app/[ecosystem]/(ui)/layout.tsx, apps/wallet-ui/src/components/ui/badge.tsx, apps/wallet-ui/src/components/ui/popover.tsx, apps/wallet-ui/src/middleware.ts, apps/wallet-ui/src/lib/assets/erc20.ts, apps/wallet-ui/src/components/ui/button.tsx, apps/wallet-ui/src/components/NftCard.tsx, apps/wallet-ui/src/components/NftGallery.tsx, apps/wallet-ui/src/lib/auth.ts, apps/wallet-ui/src/lib/assets/erc721.ts, apps/wallet-ui/src/app/[ecosystem]/(ui)/wallet/[address]/layout.tsx, apps/wallet-ui/src/util/simplehash.ts, apps/wallet-ui/src/components/ChainCombobox.tsx, apps/wallet-ui/src/components/TransactionToastProvider.tsx, apps/wallet-ui/src/app/globals.css, apps/wallet-ui/src/components/ChainIcon.tsx, apps/wallet-ui/src/components/ui/dialog.tsx, apps/wallet-ui/src/components/ui/form.tsx, apps/wallet-ui/src/components/ui/command.tsx, apps/wallet-ui/src/components/NftModal.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 8:31am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 8:31am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 8:31am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 8:31am

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 2e99057

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 25, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

gregfromstl commented Jun 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.11%. Comparing base (13764f1) to head (2e99057).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3478      +/-   ##
==========================================
- Coverage   59.12%   59.11%   -0.02%     
==========================================
  Files         958      958              
  Lines       76513    76513              
  Branches     3468     3468              
==========================================
- Hits        45241    45233       -8     
- Misses      30599    30606       +7     
- Partials      673      674       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 13764f1
packages 58.02% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2024

CodSpeed Performance Report

Merging #3478 will not alter performance

Comparing 06-24-feat_wallet-ui_setup_middleware_redirects (c4eb27a) with main (77b852a)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.06 KB (0%) 862 ms (0%) 2.5 s (-29.4% 🔽) 3.4 s
thirdweb (cjs) 92.24 KB (0%) 1.9 s (0%) 9.1 s (+33.81% 🔺) 10.9 s
thirdweb (minimal + tree-shaking) 4.81 KB (0%) 97 ms (0%) 221 ms (+0.41% 🔺) 318 ms
thirdweb/chains (tree-shaking) 492 B (0%) 10 ms (0%) 52 ms (-52.09% 🔽) 62 ms
thirdweb/react (minimal + tree-shaking) 13.96 KB (0%) 280 ms (0%) 370 ms (-14.91% 🔽) 650 ms

@gregfromstl gregfromstl force-pushed the 06-24-chore_wallet-ui_initialize_project branch from 64b5743 to ca00370 Compare June 25, 2024 17:14
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 9d4b94e to 9b674f3 Compare June 25, 2024 17:14
@gregfromstl gregfromstl force-pushed the 06-24-chore_wallet-ui_initialize_project branch from ca00370 to 07391da Compare June 25, 2024 18:13
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 9b674f3 to 59df89f Compare June 25, 2024 18:13
@gregfromstl gregfromstl force-pushed the 06-24-chore_wallet-ui_initialize_project branch from 07391da to 818c5ff Compare June 26, 2024 00:32
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 59df89f to 69eab30 Compare June 26, 2024 00:32
@gregfromstl gregfromstl mentioned this pull request Jun 26, 2024
@gregfromstl gregfromstl force-pushed the 06-24-chore_wallet-ui_initialize_project branch from 818c5ff to 5893619 Compare June 26, 2024 05:02
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 69eab30 to 3ec8539 Compare June 26, 2024 05:02
@gregfromstl gregfromstl mentioned this pull request Jun 26, 2024
4 tasks
@gregfromstl gregfromstl force-pushed the 06-24-chore_wallet-ui_initialize_project branch from 5893619 to d091b65 Compare June 26, 2024 16:26
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 17, 2024 04:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 17, 2024 04:56 Inactive
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 924424b to 02cd7b0 Compare August 17, 2024 07:37
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 17, 2024 07:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 17, 2024 07:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 17, 2024 07:37 Inactive
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 02cd7b0 to 2ef1049 Compare August 17, 2024 07:50
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 17, 2024 07:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 17, 2024 07:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 17, 2024 07:50 Inactive
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 2ef1049 to 7d9fffd Compare August 17, 2024 08:00
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Aug 17, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 17, 2024

Merge activity

  • Aug 17, 4:04 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 17, 4:04 AM EDT: gregfromstl added this pull request to the Graphite merge queue.
  • Aug 17, 4:31 AM EDT: gregfromstl merged this pull request with the Graphite merge queue.

1. Created a new `.env.example` file specifying the `NEXT_PUBLIC_ROOT_DOMAIN` variable.
2. Updated `.gitignore` to include `.env*.local` instead of `.env*`.
3. Modified the `Layout` component in `[ecosystem]/layout.tsx` to accept `children` and `params` properties and display the ecosystem and children elements.
4. Updated the `Page` component in `[ecosystem]/page.tsx` to return a simple `div` with the text `Page`.
5. Added a new `middleware.ts` file to handle dynamic routing based on the request host, matching all paths except for specific routes (e.g., `/api`, `/_next`, `/_static`). Rewrites the URL to point to either the root application or the appropriate ecosystem dynamic route.

---

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding ecosystem-related features and improving UI components.

### Detailed summary
- Added `Ecosystem` and token types
- Updated `biome.json` schema
- Implemented revalidate function
- Added NFT loading and card components
- Updated environment variables
- Improved layout and metadata handling
- Added new UI components like `Skeleton`, `Label`, and `Input`
- Enhanced client and ecosystem API integration

> The following files were skipped due to too many changes: `apps/wallet-ui/src/lib/chains.ts`, `apps/wallet-ui/src/components/ui/sonner.tsx`, `apps/wallet-ui/src/components/ConnectButton.tsx`, `apps/wallet-ui/src/app/[ecosystem]/login/page.tsx`, `apps/wallet-ui/src/app/[ecosystem]/(ui)/layout.tsx`, `apps/wallet-ui/src/components/ui/badge.tsx`, `apps/wallet-ui/src/components/ui/popover.tsx`, `apps/wallet-ui/src/middleware.ts`, `apps/wallet-ui/src/lib/assets/erc20.ts`, `apps/wallet-ui/src/components/ui/button.tsx`, `apps/wallet-ui/src/components/NftCard.tsx`, `apps/wallet-ui/src/components/NftGallery.tsx`, `apps/wallet-ui/src/lib/auth.ts`, `apps/wallet-ui/src/lib/assets/erc721.ts`, `apps/wallet-ui/src/app/[ecosystem]/(ui)/wallet/[address]/layout.tsx`, `apps/wallet-ui/src/util/simplehash.ts`, `apps/wallet-ui/src/components/ChainCombobox.tsx`, `apps/wallet-ui/src/components/TransactionToastProvider.tsx`, `apps/wallet-ui/src/app/globals.css`, `apps/wallet-ui/src/components/ChainIcon.tsx`, `apps/wallet-ui/src/components/ui/dialog.tsx`, `apps/wallet-ui/src/components/ui/form.tsx`, `apps/wallet-ui/src/components/ui/command.tsx`, `apps/wallet-ui/src/components/NftModal.tsx`, `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the 06-24-feat_wallet-ui_setup_middleware_redirects branch from 7d9fffd to 2e99057 Compare August 17, 2024 08:08
@graphite-app graphite-app bot merged commit 2e99057 into main Aug 17, 2024
@graphite-app graphite-app bot deleted the 06-24-feat_wallet-ui_setup_middleware_redirects branch August 17, 2024 08:31
kien-ngo pushed a commit that referenced this pull request Aug 20, 2024
1. Created a new `.env.example` file specifying the `NEXT_PUBLIC_ROOT_DOMAIN` variable.
2. Updated `.gitignore` to include `.env*.local` instead of `.env*`.
3. Modified the `Layout` component in `[ecosystem]/layout.tsx` to accept `children` and `params` properties and display the ecosystem and children elements.
4. Updated the `Page` component in `[ecosystem]/page.tsx` to return a simple `div` with the text `Page`.
5. Added a new `middleware.ts` file to handle dynamic routing based on the request host, matching all paths except for specific routes (e.g., `/api`, `/_next`, `/_static`). Rewrites the URL to point to either the root application or the appropriate ecosystem dynamic route.

---

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on adding ecosystem-related features and improving UI components.

### Detailed summary
- Added `Ecosystem` and token types
- Updated `biome.json` schema
- Implemented revalidate function
- Added NFT loading and card components
- Updated environment variables
- Improved layout and metadata handling
- Added new UI components like `Skeleton`, `Label`, and `Input`
- Enhanced client and ecosystem API integration

> The following files were skipped due to too many changes: `apps/wallet-ui/src/lib/chains.ts`, `apps/wallet-ui/src/components/ui/sonner.tsx`, `apps/wallet-ui/src/components/ConnectButton.tsx`, `apps/wallet-ui/src/app/[ecosystem]/login/page.tsx`, `apps/wallet-ui/src/app/[ecosystem]/(ui)/layout.tsx`, `apps/wallet-ui/src/components/ui/badge.tsx`, `apps/wallet-ui/src/components/ui/popover.tsx`, `apps/wallet-ui/src/middleware.ts`, `apps/wallet-ui/src/lib/assets/erc20.ts`, `apps/wallet-ui/src/components/ui/button.tsx`, `apps/wallet-ui/src/components/NftCard.tsx`, `apps/wallet-ui/src/components/NftGallery.tsx`, `apps/wallet-ui/src/lib/auth.ts`, `apps/wallet-ui/src/lib/assets/erc721.ts`, `apps/wallet-ui/src/app/[ecosystem]/(ui)/wallet/[address]/layout.tsx`, `apps/wallet-ui/src/util/simplehash.ts`, `apps/wallet-ui/src/components/ChainCombobox.tsx`, `apps/wallet-ui/src/components/TransactionToastProvider.tsx`, `apps/wallet-ui/src/app/globals.css`, `apps/wallet-ui/src/components/ChainIcon.tsx`, `apps/wallet-ui/src/components/ui/dialog.tsx`, `apps/wallet-ui/src/components/ui/form.tsx`, `apps/wallet-ui/src/components/ui/command.tsx`, `apps/wallet-ui/src/components/NftModal.tsx`, `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Playground Changes involving the Playground codebase. TS SDK Involves changes to the v5 TypeScript SDK.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants