Skip to content

Conversation

@MananTank
Copy link
Contributor

@MananTank MananTank commented Jul 15, 2024

PR-Codex overview

This PR focuses on fixing the issue where the Network Switcher was only showing 1 search result.

Detailed summary

  • Fixed Network Switcher showing only 1 search result in NetworkSelector.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:13pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:13pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:13pm

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: 085598c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link

linear bot commented Jul 15, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 15, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the TS SDK Involves changes to the v5 TypeScript SDK. label Jul 15, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2024

CodSpeed Performance Report

Merging #3694 will not alter performance

Comparing cnct-1498 (085598c) with main (5eddf27)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.59 KB (0%) 812 ms (0%) 1.5 s (+89.15% 🔺) 2.3 s
thirdweb (cjs) 90.5 KB (0%) 1.9 s (0%) 2 s (+7.84% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 54 ms (-54.69% 🔽) 150 ms
thirdweb/chains (tree-shaking) 433 B (0%) 10 ms (0%) 115 ms (+290.28% 🔺) 125 ms
thirdweb/react (minimal + tree-shaking) 13.56 KB (0%) 272 ms (0%) 95 ms (-12.15% 🔽) 367 ms

@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.82%. Comparing base (5eddf27) to head (085598c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3694   +/-   ##
=======================================
  Coverage   61.82%   61.82%           
=======================================
  Files         921      921           
  Lines       72067    72065    -2     
  Branches     3731     3733    +2     
=======================================
  Hits        44552    44552           
+ Misses      26827    26825    -2     
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.66% <ø> (ø) Carriedforward from 5eddf27
packages 61.13% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...src/react/web/ui/ConnectWallet/NetworkSelector.tsx 32.87% <ø> (+0.06%) ⬆️

@MananTank MananTank merged commit 817a778 into main Jul 15, 2024
@MananTank MananTank deleted the cnct-1498 branch July 15, 2024 20:18
@jnsdls jnsdls mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TS SDK Involves changes to the v5 TypeScript SDK.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants