Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jul 19, 2024

PR-Codex overview

This PR updates the AddSessionKeyOptions type in addSessionKey.ts to correct a typo and add a new parameter for the smart account contract.

Detailed summary

  • Fixed a typo from "adming" to "admin" in the type definition
  • Added a new parameter contract of type Contract for specifying the smart account contract

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:18pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:18pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:18pm

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: ec5ef50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 19, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the TS SDK Involves changes to the v5 TypeScript SDK. label Jul 19, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite Graphite

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 19, 2024

CodSpeed Performance Report

Merging #3758 will not alter performance

Comparing fix/addSessionKey-typo-jsdocs (ec5ef50) with main (83cd9e5)

Summary

✅ 9 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.27 KB (0%) 866 ms (0%) 880 ms (+180.29% 🔺) 1.8 s
thirdweb (cjs) 91.39 KB (0%) 1.9 s (0%) 937 ms (-4.52% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 29 ms (-63.49% 🔽) 125 ms
thirdweb/chains (tree-shaking) 433 B (0%) 10 ms (0%) 97 ms (+734.5% 🔺) 107 ms
thirdweb/react (minimal + tree-shaking) 13.54 KB (0%) 271 ms (0%) 117 ms (+129.35% 🔺) 387 ms

@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.61%. Comparing base (83cd9e5) to head (ec5ef50).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3758      +/-   ##
==========================================
+ Coverage   61.47%   61.61%   +0.14%     
==========================================
  Files         926      925       -1     
  Lines       73381    73109     -272     
  Branches     3732     3726       -6     
==========================================
- Hits        45108    45047      -61     
+ Misses      27589    27380     -209     
+ Partials      684      682       -2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.66% <ø> (ø) Carriedforward from 83cd9e5
packages 60.90% <100.00%> (+0.16%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...eb/src/extensions/erc4337/account/addSessionKey.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 19, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TS SDK Involves changes to the v5 TypeScript SDK.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants