[SDK] Update signTypedData domain to match contract #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch for the ERC1155 Signature Mint function in the SDK.
The current function uses the domain
TokenERC1155which should actually match the domain in the smart contract, which isSignatureMintERC1155. Because the domains do not match, the signer recovered after processing the request will always be different. This means all transactions will fail as the signer recovered is not expected.This change was also communicated and discussed with @adam-maj on Discord after a week of debugging.
Changes were tested according to contributing guidelines!