Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 1, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the UI components in the dashboard by updating styles, replacing icons, and modifying layout properties for better consistency and usability.

Detailed summary

  • Updated InputRightElement width from 145px to 160px.
  • Changed Tooltip to ToolTipLabel in OpenSeaPropertyBadge.
  • Replaced Icon with logo.icon in ConnectPlaygroundButton and CodeOptionButton.
  • Switched icon imports from react-icons to lucide-react for UploadIcon and ZapIcon.
  • Updated rightIcon in IpfsUploadButton to use UploadIcon.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 22:14 Inactive
@vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:56pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 1, 2024 11:56pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 1, 2024 11:56pm
wallet-ui ⬜️ Skipped (Inspect) Oct 1, 2024 11:56pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 22:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 22:14 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: 764ee8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 1, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

kien-ngo commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.59%. Comparing base (783d844) to head (764ee8c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4880   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files        1054     1054           
  Lines       57144    57144           
  Branches     3914     3914           
=======================================
  Hits        27196    27196           
  Misses      29260    29260           
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 783d844
packages 43.33% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.98 KB (0%) 840 ms (0%) 933 ms (+14.6% 🔺) 1.8 s
thirdweb (cjs) 101.58 KB (0%) 2.1 s (0%) 2.3 s (+23.64% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 151 ms (+20.04% 🔺) 247 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 53 ms (+54.89% 🔺) 63 ms
thirdweb/react (minimal + tree-shaking) 16.75 KB (0%) 335 ms (0%) 173 ms (-0.04% 🔽) 508 ms

@kien-ngo kien-ngo marked this pull request as ready for review October 1, 2024 22:20
@kien-ngo kien-ngo force-pushed the kien/remove-some-chakra-icons branch from f11d3bf to bc00a9e Compare October 1, 2024 22:21
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 22:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 22:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 22:21 Inactive
@kien-ngo kien-ngo force-pushed the kien/remove-some-chakra-icons branch from bc00a9e to d0f97ed Compare October 1, 2024 22:30
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 22:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 22:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 22:30 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on UI enhancements and component updates across various files in the dashboard application, including adjustments to icons, button properties, and tooltip components.

### Detailed summary
- Updated `InputRightElement` width from `145px` to `160px`.
- Changed `Tooltip` to `ToolTipLabel` in `OpenSeaPropertyBadge`.
- Modified `leftIcon` rendering in `ConnectPlaygroundButton` and `CodeOptionButton` to use class-based icons.
- Replaced `FiUpload` with `UploadIcon` in `IpfsUploadButton`.
- Swapped `BsFillLightningChargeFill` with `ZapIcon` in `ProductButton`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the kien/remove-some-chakra-icons branch from d0f97ed to 764ee8c Compare October 1, 2024 23:47
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 23:47 Inactive
@graphite-app graphite-app bot merged commit 764ee8c into main Oct 1, 2024
27 checks passed
@graphite-app graphite-app bot deleted the kien/remove-some-chakra-icons branch October 1, 2024 23:57
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 1, 2024 23:57 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 1, 2024 23:57 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 1, 2024 23:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants