Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 1, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating icon imports and usage across various components in the dashboard application, replacing FiPlus icons with PlusIcon from lucide-react and changing Upload to UploadIcon.

Detailed summary

  • Replaced Upload component with UploadIcon in airdrop-upload-erc20.tsx and upload-step.tsx.
  • Updated multiple components to use PlusIcon instead of FiPlus for consistency.
  • Removed unnecessary Icon imports from several files.
  • Adjusted icon properties for some buttons to enhance visual consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: 79c50cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:57pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 1, 2024 11:57pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 1, 2024 11:57pm
wallet-ui ⬜️ Skipped (Inspect) Oct 1, 2024 11:57pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 22:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 22:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 22:55 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 1, 2024
Copy link
Contributor Author

kien-ngo commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo changed the title Update [Dashboard] Remove react-icons (1) Oct 1, 2024
@kien-ngo kien-ngo marked this pull request as ready for review October 1, 2024 22:55
@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.59%. Comparing base (764ee8c) to head (79c50cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4882   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files        1054     1054           
  Lines       57144    57144           
  Branches     3914     3914           
=======================================
  Hits        27196    27196           
  Misses      29260    29260           
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 764ee8c
packages 43.33% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.98 KB (0%) 840 ms (0%) 444 ms (-13.16% 🔽) 1.3 s
thirdweb (cjs) 101.58 KB (0%) 2.1 s (0%) 1.1 s (+8.16% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 134 ms (+112.93% 🔺) 231 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 30 ms (+268.64% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 16.75 KB (0%) 335 ms (0%) 100 ms (+9.46% 🔺) 435 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on replacing various icon components with `PlusIcon` and `UploadIcon` from the `lucide-react` library, enhancing the UI consistency across the application.

### Detailed summary
- Replaced `Upload` component with `UploadIcon` in `airdrop-upload-erc20.tsx` and `upload-step.tsx`.
- Updated `FiPlus` icons to `PlusIcon` in multiple components, including `external-links-fieldset.tsx`, `NFTMintButton.tsx`, and more.
- Removed unused `Icon` imports from several files.
- Adjusted icon classes for consistent styling.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the kien/remove-some-chakra-icons branch from d0f97ed to 764ee8c Compare October 1, 2024 23:47
@jnsdls jnsdls force-pushed the kien/remove-react-icons-1 branch from 8749ee8 to 79c50cb Compare October 1, 2024 23:47
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 23:47 Inactive
Base automatically changed from kien/remove-some-chakra-icons to main October 1, 2024 23:57
@graphite-app graphite-app bot merged commit 79c50cb into main Oct 1, 2024
25 checks passed
@graphite-app graphite-app bot deleted the kien/remove-react-icons-1 branch October 1, 2024 23:58
@vercel vercel bot temporarily deployed to Production – docs-v2 October 1, 2024 23:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants