[Dashboard] Remove tw-components from claim condition UI #5368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5368 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 1070 1070
Lines 55671 55671
Branches 4081 4081
=======================================
Hits 25446 25446
Misses 29536 29536
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/tw-component-marketplace
branch
from
75c4d12 to
c274358
Compare
kien-ngo
force-pushed
the
kien/tw-component-claim-conditions
branch
from
03e0c1f to
d6922a7
Compare
jnsdls
approved these changes
Nov 10, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving the user interface and functionality of the `claim-conditions` components in the dashboard application. It enhances accessibility, updates styling, and refines the input handling for claim conditions.
### Detailed summary
- Updated `MaxClaimablePerWalletInput` to use `className` for styling and added a `target` attribute to the `Link`.
- Simplified `CustomFormControl` by replacing `Heading` with `FormLabel`.
- Changed `Text` components to `p` tags in `PricePreview` for better semantic structure.
- Refactored `QuantityInputWithUnlimited` to use new UI components and improved props handling.
- Enhanced `ClaimConditionsPhase` layout with Tailwind CSS classes, replacing Chakra UI components.
- Updated button styles and functionalities, including the removal button and editing toggle.
- Improved readability and structure of the phase details display.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/tw-component-marketplace
branch
from
c274358 to
453e45b
Compare
kien-ngo
force-pushed
the
kien/tw-component-claim-conditions
branch
from
d6922a7 to
8c1fa1b
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the UI components of the claim conditions form in a dashboard application. It enhances accessibility, updates styling to use Tailwind CSS, and makes adjustments to the structure of several components for better clarity and usability.
Detailed summary
MaxClaimablePerWalletInput.tsxto useclassNamefor styling instead of Chakra UI props.CustomFormControlby replacingHeadingwithFormLabel.Textcomponents toptags inPricePreviewfor consistency.QuantityInputWithUnlimitedto improve props and styling.ClaimConditionsPhase.