Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring button components across various files in the dashboard application to unify the button styling and improve accessibility by replacing the colorScheme and leftIcon props with variant, disabled, and icon placement within the button text.

Detailed summary

  • Replaced colorScheme with variant on Button components.
  • Changed isDisabled to disabled for better accessibility.
  • Moved icons inside the Button text for improved layout.
  • Updated button class names for consistent styling.
  • Removed redundant imports of Button from tw-components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: a1b518c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 0:13am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 11, 2024 0:13am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 11, 2024 0:13am
wallet-ui ⬜️ Skipped (Inspect) Nov 11, 2024 0:13am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 04:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 04:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 04:24 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 9, 2024
Copy link
Contributor Author

kien-ngo commented Nov 9, 2024

@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (8c1fa1b) to head (a1b518c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5369   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files        1070     1070           
  Lines       55671    55671           
  Branches     4081     4081           
=======================================
  Hits        25446    25446           
  Misses      29536    29536           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8c1fa1b
packages 40.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 3.5 s (+14.76% 🔺) 4.4 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 5.4 s (-6.36% 🔽) 7.5 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 293 ms (-4.39% 🔽) 391 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 38 ms (-67.49% 🔽) 48 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (0%) 352 ms (0%) 918 ms (+167.42% 🔺) 1.3 s

@kien-ngo kien-ngo force-pushed the kien/tw-component-contract-action-buttons branch from a89005b to 77ba281 Compare November 9, 2024 04:40
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 9, 2024 04:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 9, 2024 04:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 9, 2024 04:40 Inactive
@kien-ngo kien-ngo force-pushed the kien/tw-component-claim-conditions branch from 03e0c1f to d6922a7 Compare November 10, 2024 09:42
@kien-ngo kien-ngo force-pushed the kien/tw-component-contract-action-buttons branch from 77ba281 to 304c4f9 Compare November 10, 2024 09:42
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 10, 2024 09:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 10, 2024 09:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 10, 2024 09:42 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Merge activity

…5369)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the button components across various files to standardize the usage of the `Button` component from the `@/components/ui/button` module, updating properties for consistency, and improving the UI elements.

### Detailed summary
- Replaced `Button` imports from `tw-components` with `@/components/ui/button`.
- Changed `colorScheme` to `variant` for button styling.
- Updated `isDisabled` to `disabled` for button state management.
- Added `className="gap-2"` for consistent spacing.
- Modified button content to include icons before text.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@kien-ngo kien-ngo force-pushed the kien/tw-component-claim-conditions branch from d6922a7 to 8c1fa1b Compare November 11, 2024 00:10
@kien-ngo kien-ngo force-pushed the kien/tw-component-contract-action-buttons branch from 304c4f9 to a1b518c Compare November 11, 2024 00:10
Base automatically changed from kien/tw-component-claim-conditions to main November 11, 2024 00:14
@graphite-app graphite-app bot merged commit a1b518c into main Nov 11, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/tw-component-contract-action-buttons branch November 11, 2024 00:15
@vercel vercel bot temporarily deployed to Production – wallet-ui November 11, 2024 00:15 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 11, 2024 00:15 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 11, 2024 00:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants