-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Remove tw-components Button from contract action-buttons #5369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5369 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 1070 1070
Lines 55671 55671
Branches 4081 4081
=======================================
Hits 25446 25446
Misses 29536 29536
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
a89005b to
77ba281
Compare
03e0c1f to
d6922a7
Compare
77ba281 to
304c4f9
Compare
Merge activity
|
…5369) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the button components across various files to standardize the usage of the `Button` component from the `@/components/ui/button` module, updating properties for consistency, and improving the UI elements. ### Detailed summary - Replaced `Button` imports from `tw-components` with `@/components/ui/button`. - Changed `colorScheme` to `variant` for button styling. - Updated `isDisabled` to `disabled` for button state management. - Added `className="gap-2"` for consistent spacing. - Modified button content to include icons before text. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
d6922a7 to
8c1fa1b
Compare
304c4f9 to
a1b518c
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring button components across various files in the dashboard application to unify the button styling and improve accessibility by replacing the
colorSchemeandleftIconprops withvariant,disabled, and icon placement within the button text.Detailed summary
colorSchemewithvariantonButtoncomponents.isDisabledtodisabledfor better accessibility.Buttontext for improved layout.Buttonfromtw-components.