-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Feature: ConnectedWalletDetails to use headless UI #5429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
59a23e4 to
cd75491
Compare
size-limit report 📦
|
b544236 to
c5c7dd0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kien/account-components #5429 +/- ##
========================================================
Coverage 45.58% 45.59%
========================================================
Files 1076 1076
Lines 55921 55927 +6
Branches 4061 4058 -3
========================================================
+ Hits 25494 25500 +6
Misses 29740 29740
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more.
|
cd75491 to
76da5b5
Compare
c5c7dd0 to
3f95cd6
Compare
76da5b5 to
c26de55
Compare
3f95cd6 to
e4bffbf
Compare
|
changelog |
3ce5673 to
c56c615
Compare
22e4d0f to
ac39139
Compare
c56c615 to
fa0f0db
Compare
ac39139 to
3a6371b
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring the wallet connection components in the `thirdweb` package, specifically enhancing the `ConnectButton` and `ConnectedWalletDetails` components by integrating `AccountProvider` and improving the handling of wallet details.
### Detailed summary
- Updated JSDoc comment in `useConnectedWalletDetails` to indicate its limited usage.
- Wrapped `ConnectedWalletDetails` with `AccountProvider` in `ConnectButtonInner`.
- Removed `useConnectedWalletDetails` from `ConnectedWalletDetails`.
- Enhanced `ConnectedWalletDetails` to use `AccountAvatar`, `AccountName`, and `AccountBalance` components.
- Updated props handling for connected account avatar and name in `ConnectedWalletDetails`.
- Refactored balance display logic in `ConnectedWalletDetails` to use `AccountBalance`.
- Modified `DetailsModal` to utilize `AccountProvider` and improved wallet avatar handling.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
fa0f0db to
901c3a1
Compare
3a6371b to
017b13f
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the
ConnectedWalletDetailscomponent to utilize theAccountProviderfor better account management and to prepare for future changes related to the React Native package.Detailed summary
wallet.tsto indicate future removal.ConnectedWalletDetailsusage withAccountProviderinConnectButton.tsx.useConnectedWalletDetailshook usage inDetails.tsx.AccountAvatar,AccountBalance, andAccountNamecomponents for account details display.AccountBalancecomponent with improved loading states.