Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 15, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces new components and functionalities related to token management in a React application. It adds a sidebar entry for tokens and implements TokenProvider, TokenName, TokenSymbol, and TokenIcon components to manage and display token data effectively.

Detailed summary

  • Added a new sidebar entry for Token.
  • Implemented TokenProvider component for managing token context.
  • Created TokenName, TokenSymbol, and TokenIcon components for fetching and displaying token details.
  • Exported relevant types and components from the react package.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 7973d64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:43am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:43am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:43am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:43am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages labels Nov 15, 2024
Copy link
Contributor Author

kien-ngo commented Nov 15, 2024

@kien-ngo kien-ngo changed the title update [React] Headless UI: Token components <WIP> Nov 15, 2024
@kien-ngo kien-ngo marked this pull request as ready for review November 15, 2024 10:16
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 2.5 s (-20.7% 🔽) 3.4 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 5.9 s (+9.51% 🔺) 8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 343 ms (-11.4% 🔽) 455 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 84 ms (+87.62% 🔺) 94 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 724 ms (+62.91% 🔺) 1.1 s

@kien-ngo kien-ngo force-pushed the kien/token-components branch from 821efa1 to 44c97c5 Compare November 15, 2024 10:20
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (22e4d0f) to head (f6af664).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           kien/account-components-in-connect-button    #5433   +/-   ##
==========================================================================
  Coverage                                      45.59%   45.59%           
==========================================================================
  Files                                           1076     1076           
  Lines                                          55927    55927           
  Branches                                        4058     4060    +2     
==========================================================================
+ Hits                                           25500    25501    +1     
+ Misses                                         29740    29739    -1     
  Partials                                         687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 22e4d0f
packages 40.74% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces new components related to token management in a React application, including `TokenProvider`, `TokenName`, `TokenSymbol`, and `TokenIcon`. These components allow users to fetch and display token-related data such as name, symbol, and icon.

### Detailed summary
- Added `Token` section in the sidebar with links to token components.
- Created `TokenProvider` for managing token data context.
- Implemented `TokenName`, `TokenSymbol`, and `TokenIcon` components for fetching and displaying token information.
- Exported new token-related types and components from `react.ts`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants