Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 15, 2024

PR-Codex overview

This PR primarily focuses on the removal of several billing-related components and files, alongside updates to billing logic and UI components. It also introduces new functionalities for handling billing subscriptions and improves the overall structure of some components.

Detailed summary

  • Removed multiple files related to billing and pricing.
  • Updated trackedLinkButtonProps interface in button.tsx.
  • Enhanced billing plan handling in team.ts.
  • Introduced ProductSKU type in billing.ts.
  • Refactored AccountSettingsPage to remove BillingAlerts.
  • Added CheckoutButton and BillingPortalButton components.
  • Updated stories for billing components.
  • Improved usage of BillingAlerts in several components.
  • Adjusted layout and styles in various UI components.

The following files were skipped due to too many changes: apps/dashboard/src/components/onboarding/ChoosePlan.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/_components/TotalSponsoredCard.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/~/engine/(general)/create/page.tsx, apps/dashboard/src/@3rdweb-sdk/react/hooks/useApi.ts, apps/dashboard/src/app/team/[team_slug]/(team)/~/usage/page.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/~/settings/billing/components/PlanInfoCard.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/page.tsx, apps/dashboard/src/stories/stubs.ts, apps/dashboard/src/components/onboarding/ApplyForOpCreditsModal.tsx, apps/dashboard/src/components/settings/Account/Billing/Pricing.tsx, apps/dashboard/src/components/homepage/sections/PricingCard.tsx, apps/dashboard/src/utils/pricing.tsx, apps/dashboard/src/app/team/[team_slug]/(team)/~/usage/overview/components/Usage.tsx, apps/dashboard/src/components/settings/Account/Billing/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 3:21am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 20, 2024 3:21am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 20, 2024 3:21am
wallet-ui ⬜️ Skipped (Inspect) Nov 20, 2024 3:21am

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 1f60de8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 08:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 08:24 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 15, 2024
Copy link
Member Author

jnsdls commented Nov 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review November 15, 2024 08:25
@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 15, 2024 — with Graphite App
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.81%. Comparing base (3253a53) to head (2687528).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5432   +/-   ##
=======================================
  Coverage   43.81%   43.81%           
=======================================
  Files        1069     1069           
  Lines       55726    55726           
  Branches     3882     3882           
=======================================
  Hits        24415    24415           
  Misses      30628    30628           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3253a53
packages 38.50% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 656 ms (+254.05% 🔺) 1.6 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 890 ms (+88.8% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 107 ms (+548.73% 🔺) 219 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 44 ms (+998.33% 🔺) 54 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 130 ms (+67.58% 🔺) 498 ms

@jnsdls jnsdls force-pushed the 11-14-update_dependencies branch from 41c4e90 to 17c0fb4 Compare November 15, 2024 08:56
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 56050bc to c35f6c9 Compare November 15, 2024 08:56
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 08:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 08:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 08:56 Inactive
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from c35f6c9 to 8bae24b Compare November 15, 2024 08:57
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 08:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 08:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 08:57 Inactive
@jnsdls jnsdls force-pushed the 11-14-update_dependencies branch from 17c0fb4 to 8734cb7 Compare November 15, 2024 09:01
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 8bae24b to 30f5cfc Compare November 15, 2024 09:01
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 20:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 20:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 20:49 Inactive
@MananTank MananTank force-pushed the 11-14-integrate_billing_v2_init branch from 177cb3c to a887ded Compare November 19, 2024 21:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 21:43 Inactive
@MananTank MananTank force-pushed the 11-14-integrate_billing_v2_init branch from a887ded to f8aef57 Compare November 19, 2024 21:53
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 21:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 21:53 Inactive
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 2687528 to 1f60de8 Compare November 20, 2024 03:10
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 03:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 20, 2024 03:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 03:10 Inactive
@jnsdls jnsdls removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 20, 2024
@jnsdls jnsdls merged commit e95ddcd into main Nov 20, 2024
29 checks passed
@jnsdls jnsdls deleted the 11-14-integrate_billing_v2_init branch November 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants