Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 15, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring billing-related components and types in the application, enhancing the onboarding process, and improving the pricing structure for different user plans. It also includes the removal of deprecated files and introduces new functionalities for managing billing and account settings.

Detailed summary

  • Deleted several unused files related to onboarding and billing.
  • Refactored TrackedLinkButtonProps to simplify its interface.
  • Updated billingPlan to include a new "starter" option.
  • Modified teamStub function to use the updated billing plan type.
  • Renamed LazyOnboardingBilling to LazyAddPaymentMethod.
  • Changed OnboardingModal to TWModal with updated props.
  • Improved account fetching logic in getAccount.
  • Refactored TeamPlanBadge to use the new billing plan type.
  • Simplified the logic for determining valid team plans in getValidTeamPlan.
  • Enhanced CreditsItem and BillingPricing components for better display and management of billing information.
  • Updated the PricingSection to reflect changes in billing plans and CTA links.
  • Introduced PlanInfoCard to display account and usage billing details effectively.
  • Removed unnecessary state management related to payment methods in several components.

The following files were skipped due to too many changes: apps/dashboard/src/components/homepage/sections/PricingCard.tsx, apps/dashboard/src/components/settings/Account/Billing/index.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: b673c68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 18:07 Inactive
@vercel
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 11:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Nov 15, 2024 11:45pm
thirdweb-www ⬜️ Skipped (Inspect) Nov 15, 2024 11:45pm
wallet-ui ⬜️ Skipped (Inspect) Nov 15, 2024 11:45pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 18:07 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

MananTank commented Nov 15, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 15, 2024
@MananTank MananTank marked this pull request as ready for review November 15, 2024 18:07
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.53%. Comparing base (a258674) to head (b673c68).
Report is 1 commits behind head on 11-14-integrate_billing_v2_init.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           11-14-integrate_billing_v2_init    #5436   +/-   ##
================================================================
  Coverage                            45.53%   45.53%           
================================================================
  Files                                 1070     1070           
  Lines                                55690    55690           
  Branches                              4033     4033           
================================================================
  Hits                                 25356    25356           
  Misses                               29647    29647           
  Partials                               687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <0.00%> (ø) Carriedforward from 1c14649
packages 40.63% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.88 KB (0%) 898 ms (0%) 191 ms (+12.09% 🔺) 1.1 s
thirdweb (cjs) 105.07 KB (0%) 2.2 s (0%) 430 ms (+8.03% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 30 ms (+299.87% 🔺) 145 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 36 ms (+1350.21% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 80 ms (+380.48% 🔺) 456 ms

@MananTank MananTank force-pushed the 11-15-billing_v2_ui_changes branch from 893673b to ef8ef74 Compare November 15, 2024 18:50
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 18:50 Inactive
@MananTank MananTank force-pushed the 11-15-billing_v2_ui_changes branch from ef8ef74 to d8ea0ce Compare November 15, 2024 19:20
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 19:20 Inactive
@MananTank MananTank force-pushed the 11-15-billing_v2_ui_changes branch from 8f6c3c1 to 1c14649 Compare November 15, 2024 21:17
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 15, 2024 21:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 21:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 21:17 Inactive
@gregfromstl gregfromstl changed the title Billing V2 UI changes [Dsahboard] Feature: Billing V2 UI changes Nov 15, 2024
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from f9306cf to a258674 Compare November 15, 2024 23:19
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 15, 2024 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 15, 2024 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 15, 2024 23:24 Inactive
@jnsdls jnsdls merged commit 8359304 into 11-14-integrate_billing_v2_init Nov 15, 2024
19 of 21 checks passed
@jnsdls jnsdls deleted the 11-15-billing_v2_ui_changes branch November 15, 2024 23:24
jnsdls added a commit that referenced this pull request Nov 15, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
jnsdls added a commit that referenced this pull request Nov 16, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
jnsdls added a commit that referenced this pull request Nov 16, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
MananTank added a commit that referenced this pull request Nov 18, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
MananTank added a commit that referenced this pull request Nov 18, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
MananTank added a commit that referenced this pull request Nov 18, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
MananTank added a commit that referenced this pull request Nov 18, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
jnsdls added a commit that referenced this pull request Nov 19, 2024
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants