Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 19, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the account settings functionality by implementing email confirmation, account updates, and user feedback mechanisms. It introduces new actions, modifies existing components, and improves user experience with better error handling.

Detailed summary

  • Added "/account/settings" route in layout.tsx.
  • Revised email confirmation logic in index.tsx.
  • Updated waitlist joining logic in nebula-waitlist-page.tsx.
  • Enhanced error handling in joinWaitlist.ts and updateAccount.ts.
  • Implemented email confirmation with OTP in confirmEmail.ts.
  • Improved AccountSettingsPage.tsx to include email and name update functionalities.
  • Updated AccountSettingsPageUI.tsx to handle email and name updates.
  • Enhanced EmailUpdateDialog to manage OTP and email updates.
  • Added state management for email verification in AccountSettingsPageUI.stories.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 9:04pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 20, 2024 9:04pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 20, 2024 9:04pm
wallet-ui ⬜️ Skipped (Inspect) Nov 20, 2024 9:04pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 20:42 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: a67e980

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 20:42 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 19, 2024
Copy link
Member Author

MananTank commented Nov 19, 2024

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.88%. Comparing base (4c8333d) to head (a67e980).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5461   +/-   ##
=======================================
  Coverage   43.88%   43.88%           
=======================================
  Files        1075     1075           
  Lines       55944    55944           
  Branches     3910     3910           
=======================================
  Hits        24550    24550           
  Misses      30711    30711           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4c8333d
packages 38.61% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 284 ms (-22.89% 🔽) 1.2 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 1.1 s (+9.61% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 138 ms (+681.77% 🔺) 250 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 7 ms (+11.51% 🔺) 17 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 158 ms (+120.37% 🔺) 525 ms

@MananTank MananTank force-pushed the 11-20-add_account_settings_page_with_name_and_email_fields branch from 9dc0c9a to 17d8f93 Compare November 19, 2024 20:48
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 20:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 20:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 20:48 Inactive
@MananTank MananTank marked this pull request as ready for review November 19, 2024 21:05
@MananTank MananTank force-pushed the 11-20-add_account_settings_page_with_name_and_email_fields branch from 17d8f93 to 6c24a63 Compare November 19, 2024 22:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 22:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 22:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 22:19 Inactive
@gregfromstl gregfromstl changed the title Add account settings page with Name and Email fields [Dashboard] Feature: Add account settings page with Name and Email fields Nov 20, 2024
@MananTank MananTank force-pushed the 11-20-add_account_settings_page_with_name_and_email_fields branch from 6c24a63 to 1cf99be Compare November 20, 2024 11:13
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 11:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 20, 2024 11:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 11:13 Inactive
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to handle errors from API server when trying to update to an email that another account already has set - api call fails but generic RSC error shows to user

image.png

also should now allow updating to proceed if the email entered is the same as the currently verified email

@MananTank MananTank force-pushed the 11-20-add_account_settings_page_with_name_and_email_fields branch from 1cf99be to caa6968 Compare November 20, 2024 18:49
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 20, 2024 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 18:49 Inactive
Copy link
Member Author

Fixed

  • error message from server action
  • disabled submit button if form is not dirty

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2024

Merge activity

…elds (#5461)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the account settings functionality, including email confirmation and account updates, while improving error handling and user interactions.

### Detailed summary
- Added a new route for `/account/settings`.
- Improved onboarding logic for email confirmation.
- Updated waitlist joining logic to handle responses better.
- Enhanced `joinTeamWaitlist` and `updateAccount` actions with better error handling.
- Implemented email confirmation with OTP in `confirmEmailWithOTP`.
- Improved `AccountSettingsPage` to include email update functionalities.
- Added UI components for email verification and account updates.
- Refined error handling in various components for better user feedback.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-20-add_account_settings_page_with_name_and_email_fields branch from caa6968 to a67e980 Compare November 20, 2024 21:00
@graphite-app graphite-app bot merged commit a67e980 into main Nov 20, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 11-20-add_account_settings_page_with_name_and_email_fields branch November 20, 2024 21:05
@vercel vercel bot temporarily deployed to Production – docs-v2 November 20, 2024 21:05 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 20, 2024 21:05 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 20, 2024 21:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants