Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 20, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the onboarding and authentication processes in the application. It introduces checks for team existence, improves error handling, and refines the user experience during login and account management.

Detailed summary

  • Added optional chaining to safely access the first team.
  • Implemented loginRedirect function to handle login redirection.
  • Created getValidAccount to enforce onboarding checks.
  • Refactored IconLogo to use a constant instead of export.
  • Improved team fetching logic with null handling.
  • Updated onboarding components for better user flow.
  • Enhanced email confirmation with error handling and user feedback.
  • Adjusted UI components for consistency and clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 776f5aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 1:21am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 21, 2024 1:21am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 21, 2024 1:21am
wallet-ui ⬜️ Skipped (Inspect) Nov 21, 2024 1:21am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 20, 2024 17:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 17:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 17:39 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review November 20, 2024 17:39
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 20, 2024
Copy link
Member Author

MananTank commented Nov 20, 2024

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.88%. Comparing base (ecaa304) to head (776f5aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5471   +/-   ##
=======================================
  Coverage   43.88%   43.88%           
=======================================
  Files        1075     1075           
  Lines       55944    55944           
  Branches     3910     3910           
=======================================
  Hits        24550    24550           
  Misses      30711    30711           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ecaa304
packages 38.61% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 2.9 s (+2.68% 🔺) 3.8 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 6.4 s (-0.83% 🔽) 8.5 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 425 ms (+141.3% 🔺) 537 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 65 ms (-58.1% 🔽) 75 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 469 ms (-56.66% 🔽) 837 ms

@MananTank MananTank force-pushed the 11-20-user_onboarding_ui_revamp branch from 91f69e2 to 990d40d Compare November 20, 2024 17:46
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 20, 2024 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 17:46 Inactive
@MananTank MananTank changed the title User Onboarding UI Revamp User Onboarding Revamp Nov 20, 2024
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. create new user (inapp)
  2. create thirdweb acc
  3. confirm email
  4. pick "free" option

result:

image.png

stuck here

Copy link
Member Author

MananTank commented Nov 20, 2024

I see the issue - onComplete callback is not called here

@MananTank MananTank force-pushed the 11-20-add_account_settings_page_with_name_and_email_fields branch from 1cf99be to caa6968 Compare November 20, 2024 18:49
@MananTank MananTank force-pushed the 11-20-user_onboarding_ui_revamp branch from 990d40d to 88ecbc4 Compare November 20, 2024 18:49
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 20, 2024 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 20, 2024 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 20, 2024 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 20, 2024 21:06 Inactive
@MananTank MananTank force-pushed the 11-20-user_onboarding_ui_revamp branch from a1f606a to c95164e Compare November 21, 2024 00:37
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 21, 2024 00:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 21, 2024 00:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 21, 2024 00:38 Inactive
@MananTank MananTank force-pushed the 11-20-user_onboarding_ui_revamp branch from c95164e to e8bd033 Compare November 21, 2024 00:53
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 21, 2024 00:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 21, 2024 00:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 21, 2024 00:53 Inactive
@MananTank MananTank requested a review from jnsdls November 21, 2024 01:04
Copy link
Member Author

Fixed now

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the onboarding process and account management in the application. It introduces better handling of team retrieval, login redirection, and email confirmation, while also refining the UI components related to these features.

### Detailed summary
- Added optional chaining for `firstTeam` retrieval.
- Introduced `loginRedirect` function for consistent login handling.
- Created `getValidAccount` to enforce login and onboarding checks.
- Improved `Onboarding` components for better user experience.
- Enhanced email confirmation flow with clearer messaging.
- Updated various components to use new account and team management functions.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 11-20-user_onboarding_ui_revamp branch from e8bd033 to 776f5aa Compare November 21, 2024 01:18
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 21, 2024 01:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 21, 2024 01:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 21, 2024 01:18 Inactive
@graphite-app graphite-app bot merged commit 776f5aa into main Nov 21, 2024
30 of 31 checks passed
@graphite-app graphite-app bot deleted the 11-20-user_onboarding_ui_revamp branch November 21, 2024 01:21
@vercel vercel bot temporarily deployed to Production – docs-v2 November 21, 2024 01:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 21, 2024 01:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 21, 2024 01:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants