Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 2, 2024

fixes: DASH-500


PR-Codex overview

This PR focuses on the removal of several components and pages related to the dashboard and the addition of redirect rules for certain routes to an external portal.

Detailed summary

  • Deleted the following files:
    • sdk.tsx
    • storage.tsx
    • rpc-edge.tsx
    • Hero.tsx
    • SDKSection.tsx
    • GuideShowcase.tsx
    • ProductSection.tsx
    • CodeSelector.tsx
    • CodeOptionButton.tsx
    • ProductLearnMoreCard.tsx
  • Added redirect rules in redirects.js for:
    • /storage to https://portal.thirdweb.com/infrastructure/storage/overview
    • /rpc-edge to https://portal.thirdweb.com/infrastructure/rpc-edge/overview
    • /sdk to https://portal.thirdweb.com/connect/blockchain-api
  • Updated page-id.ts by removing references to:
    • Web3SDKLanding
    • RPCEdgeLanding

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 18:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 18:39 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 71c968b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:43pm
thirdweb_playground ❌ Failed (Inspect) Dec 2, 2024 8:43pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:43pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:43pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 18:39 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls marked this pull request as ready for review December 2, 2024 18:39
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 2, 2024
Copy link
Member Author

jnsdls commented Dec 2, 2024

@linear
Copy link

linear bot commented Dec 2, 2024

@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.32%. Comparing base (149ee05) to head (71c968b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5553   +/-   ##
=======================================
  Coverage   46.32%   46.32%           
=======================================
  Files        1082     1082           
  Lines       58672    58672           
  Branches     3950     3950           
=======================================
  Hits        27178    27178           
  Misses      30811    30811           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 149ee05
packages 41.91% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 3 s (-16.22% 🔽) 4 s
thirdweb (cjs) 107.33 KB (0%) 2.2 s (0%) 7 s (-1.87% 🔽) 9.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 269 ms (+18.05% 🔺) 380 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 54 ms (+10.25% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 723 ms (+34.81% 🔺) 1.1 s

This was referenced Dec 2, 2024
@jnsdls jnsdls force-pushed the 12-02-remove_and_redirect_old_landing_pages branch from 923acf3 to 71c968b Compare December 2, 2024 18:50
@jnsdls jnsdls merged commit 009d31b into main Dec 2, 2024
30 of 32 checks passed
@jnsdls jnsdls deleted the 12-02-remove_and_redirect_old_landing_pages branch December 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants