Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 2, 2024

fixes: DASH-503


PR-Codex overview

This PR primarily focuses on the removal of several components related to contracts and updates to routing paths in the application.

Detailed summary

  • Deleted the following files:
    • apps/dashboard/src/pages/contracts.tsx
    • apps/dashboard/src/components/contracts/Stats.tsx
    • apps/dashboard/src/components/contracts/CaseStudyStatic.tsx
    • apps/dashboard/src/components/contracts/ContractInteractionSection.tsx
    • apps/dashboard/src/components/contracts/LandingCaseStudyStaticSection.tsx
  • Updated apps/dashboard/src/page-id.ts by removing:
    • ContractsLanding = "contracts-landing"
  • Modified apps/dashboard/framer-rewrites.js:
    • Added new routes under // -- nebula and // -- TPP sections.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: ea855c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 10:50pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 2, 2024 10:50pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 2, 2024 10:50pm
wallet-ui ⬜️ Skipped (Inspect) Dec 2, 2024 10:50pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 21:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 21:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 21:21 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 2, 2024
@jnsdls jnsdls mentioned this pull request Dec 2, 2024
Copy link
Member Author

jnsdls commented Dec 2, 2024

@jnsdls jnsdls mentioned this pull request Dec 2, 2024
@linear
Copy link

linear bot commented Dec 2, 2024

@jnsdls jnsdls marked this pull request as ready for review December 2, 2024 21:22
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.98%. Comparing base (125de5f) to head (ea855c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5591   +/-   ##
=======================================
  Coverage   43.98%   43.98%           
=======================================
  Files        1082     1082           
  Lines       56235    56235           
  Branches     3954     3954           
=======================================
  Hits        24737    24737           
  Misses      30815    30815           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 125de5f
packages 38.78% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 3.4 s (+12.23% 🔺) 4.3 s
thirdweb (cjs) 107.39 KB (0%) 2.2 s (0%) 7 s (-6.94% 🔽) 9.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 172 ms (-75.37% 🔽) 284 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+3.05% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 18.27 KB (0%) 366 ms (0%) 665 ms (+37.45% 🔺) 1.1 s

Base automatically changed from 12-02-update_typedoc to main December 2, 2024 21:43
@jnsdls jnsdls requested a review from gregfromstl as a code owner December 2, 2024 21:43
@jnsdls jnsdls force-pushed the 12-02-trusted_partner_program_remove__contracts branch from abe7cc5 to 672dbfc Compare December 2, 2024 21:44
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 21:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 21:44 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 21:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 2, 2024 22:15 Inactive
@jnsdls jnsdls force-pushed the 12-02-trusted_partner_program_remove__contracts branch from 672dbfc to 65458bd Compare December 2, 2024 22:15
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 22:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 22:15 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Merge activity

fixes: DASH-503

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on the removal of several components and pages related to contracts in the dashboard, along with updates to routing configurations.

### Detailed summary
- Deleted the following files:
  - `contracts.tsx`
  - `Stats.tsx`
  - `CaseStudyStatic.tsx`
  - `ContractInteractionSection.tsx`
  - `LandingCaseStudyStaticSection.tsx`
- Updated `page-id.ts` by modifying the `ContractsLanding` constant.
- Modified `framer-rewrites.js` to add new routes:
  - `/nebula`
  - `/trusted-partner-program`
  - `/trusted-partner-program/:partner_slug`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-02-trusted_partner_program_remove__contracts branch from 65458bd to ea855c6 Compare December 2, 2024 22:40
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 22:40 Inactive
@graphite-app graphite-app bot merged commit ea855c6 into main Dec 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-02-trusted_partner_program_remove__contracts branch December 2, 2024 22:51
@vercel vercel bot temporarily deployed to Production – docs-v2 December 2, 2024 22:51 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 2, 2024 22:51 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 2, 2024 22:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants