[TOOL-3173] Portal: Update hero image, OG image on landing page #6017

MananTank · 2025-01-21T22:35:40Z

PR-Codex overview

This PR focuses on updating the images used in the RootLayout and Page components of the thirdweb developer portal, enhancing the theme-based display of hero images.

Detailed summary

Deleted the old image docs-hero.png.
Added docs-hero-dark.png and docs-hero-light.png.
Updated the RootLayout to include theme-based CSS for light and dark themes.
Replaced DocsHero with DocsHeroDark and DocsHeroLight in the Hero component, applying corresponding class names for theme visibility.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2025-01-21T22:35:42Z

TOOL-3173 Update Portal Hero + OG Image on landing page

changeset-bot · 2025-01-21T22:35:43Z

⚠️ No Changeset found

Latest commit: 80a22ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-01-21T22:35:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 4:23pm

3 Skipped Deployments

Name	Status	Updated (UTC)
thirdweb_playground	⬜️ Skipped (Inspect)	Jan 22, 2025 4:23pm
thirdweb-www	⬜️ Skipped (Inspect)	Jan 22, 2025 4:23pm
wallet-ui	⬜️ Skipped (Inspect)	Jan 22, 2025 4:23pm

MananTank · 2025-01-21T22:35:59Z

[TOOL-3173] Portal: Update hero image, OG image on landing page #6017 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

apps/portal/src/app/page.tsx

codecov · 2025-01-21T22:37:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.90%. Comparing base (eefa2ab) to head (80a22ff).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6017   +/-   ##
=======================================
  Coverage   54.90%   54.90%           
=======================================
  Files        1151     1151           
  Lines       61201    61201           
  Branches     5160     5160           
=======================================
  Hits        33601    33601           
  Misses      26874    26874           
  Partials      726      726

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from eefa2ab
packages	`52.57% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2025-01-21T22:39:08Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	46.68 KB (0%)	934 ms (0%)	3.5 s (+50.78% 🔺)	4.4 s
thirdweb (cjs)	116.87 KB (0%)	2.4 s (0%)	8.7 s (+49.1% 🔺)	11.1 s
thirdweb (minimal + tree-shaking)	5.59 KB (0%)	112 ms (0%)	382 ms (+90.5% 🔺)	494 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	56 ms (-0.67% 🔽)	66 ms
thirdweb/react (minimal + tree-shaking)	19.22 KB (0%)	385 ms (0%)	424 ms (-53.22% 🔽)	809 ms

joaquim-verges

i see this on small window width

graphite-app · 2025-01-22T07:51:33Z

Merge activity

Jan 22, 2:51 AM EST: A user added this pull request to the Graphite merge queue.
Jan 22, 2:52 AM EST: A user removed this pull request from the Graphite merge queue.
Jan 22, 12:01 PM EST: A user added this pull request to the Graphite merge queue.
Jan 22, 12:02 PM EST: A user merged this pull request with the Graphite merge queue.

joaquim-verges

header layout issue

MananTank · 2025-01-22T16:18:01Z

Ok found the issue, dark theme is the default - so does not require a [data-theme="dark"] attribute set for it to be dark theme - but light theme has to have [data-theme="light"]. It worked when I tested locally because I had already switched the theme multiple times and that caused it to always have a data-theme attribute present on body, which is not the case if you visit the website for the first time. Updated CSS selector to fix this.

jnsdls · 2025-01-22T17:00:52Z

apps/portal/src/app/globals.css

+/* If no data-theme is added in body, its in dark theme  */
+body:not([data-theme="light"]) .light-only {
+  display: none;
+}
+
+[data-theme="light"] .dark-only {
+  display: none;
+}
+


is this due to chakra & tailwind mixing?

No, we don't have chakra in portal, We have custom "theme provider" setup that sets a data-theme attribute in portal

resolved

vercel bot temporarily deployed to Preview – thirdweb_playground January 21, 2025 22:35 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 21, 2025 22:35 Inactive

vercel bot temporarily deployed to Preview – thirdweb-www January 21, 2025 22:35 Inactive

github-actions bot assigned MananTank Jan 21, 2025

github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 21, 2025

MananTank marked this pull request as ready for review January 21, 2025 22:36

MananTank requested review from a team as code owners January 21, 2025 22:36

graphite-app bot reviewed Jan 21, 2025

View reviewed changes

apps/portal/src/app/page.tsx Show resolved Hide resolved

vercel bot deployed to Preview – docs-v2 January 21, 2025 22:43 View deployment

joaquim-verges reviewed Jan 21, 2025

View reviewed changes

joaquim-verges approved these changes Jan 22, 2025

View reviewed changes

joaquim-verges previously requested changes Jan 22, 2025

View reviewed changes

MananTank added a commit that referenced this pull request Jan 22, 2025

[TOOL-3173] Portal: Update hero iamge, OG image on landing page (#6017)

d9d023e

MananTank force-pushed the TOOL-3173 branch from ab2d385 to d9d023e Compare January 22, 2025 07:52

vercel bot temporarily deployed to Preview – thirdweb-www January 22, 2025 07:52 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 07:52 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 07:52 Inactive

vercel bot deployed to Preview – docs-v2 January 22, 2025 07:59 View deployment

MananTank added a commit that referenced this pull request Jan 22, 2025

[TOOL-3173] Portal: Update hero iamge, OG image on landing page (#6017)

f0de2f4

MananTank force-pushed the TOOL-3173 branch from d9d023e to f0de2f4 Compare January 22, 2025 15:14

vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 15:14 Inactive

vercel bot temporarily deployed to Preview – thirdweb-www January 22, 2025 15:14 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 15:14 Inactive

vercel bot deployed to Preview – docs-v2 January 22, 2025 15:21 View deployment

MananTank marked this pull request as draft January 22, 2025 16:11

[TOOL-3173] Portal: Update hero iamge, OG image on landing page (#6017)

80a22ff

MananTank force-pushed the TOOL-3173 branch from f0de2f4 to 80a22ff Compare January 22, 2025 16:16

MananTank changed the title ~~[TOOL-3173] Portal: Update hero iamge, OG image on landing page~~ [TOOL-3173] Portal: Update hero image, OG image on landing page Jan 22, 2025

vercel bot temporarily deployed to Preview – thirdweb_playground January 22, 2025 16:16 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 22, 2025 16:16 Inactive

vercel bot temporarily deployed to Preview – thirdweb-www January 22, 2025 16:16 Inactive

MananTank marked this pull request as ready for review January 22, 2025 16:18

MananTank requested a review from joaquim-verges January 22, 2025 16:19

vercel bot deployed to Preview – docs-v2 January 22, 2025 16:23 View deployment

jnsdls approved these changes Jan 22, 2025

View reviewed changes

graphite-app bot merged commit 80a22ff into main Jan 22, 2025
35 checks passed

graphite-app bot deleted the TOOL-3173 branch January 22, 2025 17:02

vercel bot temporarily deployed to Production – thirdweb_playground January 22, 2025 17:02 Inactive

vercel bot temporarily deployed to Production – wallet-ui January 22, 2025 17:02 Inactive

vercel bot temporarily deployed to Production – thirdweb-www January 22, 2025 17:02 Inactive

vercel bot deployed to Production – docs-v2 January 22, 2025 17:04 View deployment

[TOOL-3173] Portal: Update hero image, OG image on landing page #6017

[TOOL-3173] Portal: Update hero image, OG image on landing page #6017

Uh oh!

Conversation

MananTank commented Jan 21, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Jan 21, 2025

Uh oh!

changeset-bot bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Jan 21, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

codecov bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

joaquim-verges left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

joaquim-verges left a comment

Choose a reason for hiding this comment

Uh oh!

MananTank commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jnsdls Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

MananTank Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MananTank commented Jan 21, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented Jan 21, 2025 •

edited

Loading

vercel bot commented Jan 21, 2025 •

edited

Loading

codecov bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

graphite-app bot commented Jan 22, 2025 •

edited

Loading

MananTank commented Jan 22, 2025 •

edited

Loading