Skip to content

[TOOL-3173] Portal: Update hero image, OG image on landing page #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[TOOL-3173] Portal: Update hero image, OG image on landing page #6017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added apps/portal/src/app/_images/docs-hero-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added apps/portal/src/app/_images/docs-hero-light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed apps/portal/src/app/_images/docs-hero.png
View file
Open in desktop
Binary file not shown.
9 changes: 9 additions & 0 deletions apps/portal/src/app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,15 @@ html {
}
}

/* If no data-theme is added in body, its in dark theme */
body:not([data-theme="light"]) .light-only {
display: none;
}

[data-theme="light"] .dark-only {
display: none;
}

Comment on lines +96 to +104
Copy link
Member

@jnsdls jnsdls Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this due to chakra & tailwind mixing?

Copy link
Member Author

@MananTank MananTank Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't have chakra in portal, We have custom "theme provider" setup that sets a data-theme attribute in portal

code span {
color: var(--code-dark-color);
}
Expand Down
4 changes: 0 additions & 4 deletions apps/portal/src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ const monoFont = Fira_Code({
export const metadata = createMetadata({
title: "thirdweb docs",
description: "thirdweb developer portal",
image: {
title: "Build apps and games on any EVM chain",
icon: "thirdweb",
},
});

export default function RootLayout({
Expand Down
Binary file added apps/portal/src/app/opengraph-image.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 4 additions & 2 deletions apps/portal/src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { Heading } from "@/components/Document";
import Image from "next/image";
import Link from "next/link";
import DocsHero from "./_images/docs-hero.png";
import DocsHeroDark from "./_images/docs-hero-dark.png";
import DocsHeroLight from "./_images/docs-hero-light.png";

export default function Page() {
return (
Expand Down Expand Up @@ -34,7 +35,8 @@ function Hero() {

{/* right */}
<div className="hidden justify-center lg:flex">
<Image src={DocsHero} alt="" className="w-full" />
<Image src={DocsHeroDark} alt="" className="dark-only w-full" />
<Image src={DocsHeroLight} alt="" className="light-only w-full" />
</div>
</section>
);
Expand Down
Loading