-
Couldn't load subscription status.
- Fork 611
[Docs] Add guide for using ConnectButton with wagmi application #8294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add guide for using ConnectButton with wagmi application #8294
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8294 +/- ##
=======================================
Coverage 54.90% 54.90%
=======================================
Files 919 919
Lines 60665 60665
Branches 4129 4129
=======================================
Hits 33310 33310
Misses 27254 27254
Partials 101 101
🚀 New features to boost your workflow:
|
size-limit report 📦
|
9627d76 to
aff0a46
Compare
WalkthroughDocumentation for wagmi and thirdweb in-app wallet integration was expanded in the portal. The changes replace a brief note with comprehensive guidance on ConnectButton/ConnectEmbed usage, update the headless connector example, and add details on automatic reconnect behavior and useAutoConnect hook. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
aff0a46 to
1586f15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/portal/src/app/wallets/adapters/page.mdx (2)
66-101: Documentation structure and integration example are clear and well-explained.The new section effectively explains the ConnectButton/ConnectEmbed integration pattern, includes a proper code example showing connector lookup and connection via onConnect callback, and provides important guidance about provider wrapping and automatic reconnect behavior. The progression from basic to headless usage is logical.
One minor style issue: Line 68 should use "etc." with a period.
Apply this diff to fix the punctuation:
-You can use the thirdweb react connection components and hooks like ConnectButton, ConnectEmbed, useConnectModal, etc, but still keep using wagmi for the rest of the application. +You can use the thirdweb react connection components and hooks like ConnectButton, ConnectEmbed, useConnectModal, etc., but still keep using wagmi for the rest of the application.
123-123: Capitalize "React" and consider removing wordiness.Line 123 has two minor style issues: "react" should be capitalized as "React" (proper noun), and "all of the react components" reads better as "all the react components" for conciseness.
Apply this diff:
-You can also use the thirdweb SDK within a wagmi application by setting the wagmi connected account as the thirdweb 'active wallet'. After that, you can use all of the react components and hooks normally, including `BuyWidget`, `TransactionButton`, etc. +You can also use the thirdweb SDK within a wagmi application by setting the wagmi connected account as the thirdweb 'active wallet'. After that, you can use all the React components and hooks normally, including `BuyWidget`, `TransactionButton`, etc.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/portal/src/app/wallets/adapters/page.mdx(2 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/portal/src/app/wallets/adapters/page.mdx
[style] ~68-~68: In American English, abbreviations like “etc.” require a period.
Context: ...tButton, ConnectEmbed, useConnectModal, etc, but still keep using wagmi for the res...
(ETC_PERIOD)
[style] ~123-~123: Consider removing “of” to be more concise
Context: ...active wallet'. After that, you can use all of the react components and hooks normally, in...
(ALL_OF_THE)
[uncategorized] ~123-~123: “React” is a proper noun and needs to be capitalized.
Context: ...et'. After that, you can use all of the react components and hooks normally, includin...
(A_GOOGLE)
🔇 Additional comments (1)
apps/portal/src/app/wallets/adapters/page.mdx (1)
106-118: Headless connector example is correct and well-demonstrated.The updated code example properly shows direct inAppWallet connector usage with an explicit strategy parameter. The pattern is consistent with the ConnectButton example and demonstrates proper integration.

PR-Codex overview
This PR enhances the documentation for integrating
thirdwebwithwagmi, specifically focusing on using theinAppWalletConnectorandConnectButtonorConnectEmbed. It provides code examples and emphasizes the importance of wrapping the app in both providers.Detailed summary
ConnectButtonorConnectEmbedwithwagmi.inAppWalletConnector.<ThirdwebProvider>and<WagmiProvider>.ConnectButtonandConnectEmbed.<ThirdwebProvider>.Summary by CodeRabbit