Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 22, 2025


PR-Codex overview

This PR enhances the documentation for integrating thirdweb with wagmi, specifically focusing on using the inAppWalletConnector and ConnectButton or ConnectEmbed. It provides code examples and emphasizes the importance of wrapping the app in both providers.

Detailed summary

  • Added section on using ConnectButton or ConnectEmbed with wagmi.
  • Included code example for connecting inAppWalletConnector.
  • Mentioned the need to wrap the app in <ThirdwebProvider> and <WagmiProvider>.
  • Explained automatic reconnection with ConnectButton and ConnectEmbed.
  • Added note on using the connector directly without <ThirdwebProvider>.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation
    • Enhanced wallet integration guides with detailed instructions for connecting wagmi and thirdweb in-app wallets
    • Added comprehensive usage examples for ConnectButton and ConnectEmbed components in wagmi applications
    • Included practical headless connector examples demonstrating various authentication strategies
    • Expanded guidance on automatic reconnect behavior and implementation best practices

@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 22, 2025 6:27pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Oct 22, 2025 6:27pm
thirdweb_playground Skipped Skipped Oct 22, 2025 6:27pm
thirdweb-www Skipped Skipped Oct 22, 2025 6:27pm
wallet-ui Skipped Skipped Oct 22, 2025 6:27pm

@vercel vercel bot temporarily deployed to Preview – nebula October 22, 2025 17:48 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

⚠️ No Changeset found

Latest commit: 1586f15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2025 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 22, 2025 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2025 17:48 Inactive
Copy link
Member Author

joaquim-verges commented Oct 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.90%. Comparing base (6a7b556) to head (1586f15).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8294   +/-   ##
=======================================
  Coverage   54.90%   54.90%           
=======================================
  Files         919      919           
  Lines       60665    60665           
  Branches     4129     4129           
=======================================
  Hits        33310    33310           
  Misses      27254    27254           
  Partials      101      101           
Flag Coverage Δ
packages 54.90% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.55 KB (0%) 1.3 s (0%) 190 ms (+306.49% 🔺) 1.5 s
thirdweb (cjs) 365.82 KB (0%) 7.4 s (0%) 595 ms (+22.57% 🔺) 8 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 108 ms (+3742.59% 🔺) 222 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 89 ms (+3859.95% 🔺) 100 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 88 ms (+2667.3% 🔺) 470 ms

@joaquim-verges joaquim-verges force-pushed the _Docs_Add_guide_for_using_ConnectButton_with_wagmi_application branch from 9627d76 to aff0a46 Compare October 22, 2025 18:07
@vercel vercel bot temporarily deployed to Preview – nebula October 22, 2025 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 22, 2025 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2025 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2025 18:07 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Walkthrough

Documentation for wagmi and thirdweb in-app wallet integration was expanded in the portal. The changes replace a brief note with comprehensive guidance on ConnectButton/ConnectEmbed usage, update the headless connector example, and add details on automatic reconnect behavior and useAutoConnect hook.

Changes

Cohort / File(s) Summary
Documentation Expansion
apps/portal/src/app/wallets/adapters/page.mdx
Expanded integration guidance with detailed ConnectButton/ConnectEmbed setup for wagmi apps, updated headless connector example with explicit in-app wallet connector retrieval and strategy parameter, added automatic reconnect behavior notes and useAutoConnect guidance, reordered content sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description does not follow the repository's required template structure. The template specifies sections for "Notes for the reviewer" and "How to test", along with formatting guidelines for the PR title (though the title itself is formatted correctly in the PR title field). Instead of following this structure, the description contains only PR-Codex generated content with an overview and detailed summary of changes. While the PR-Codex content does provide useful information about the documentation changes, the description is largely missing the standard template sections that help reviewers understand testing requirements and any special considerations. The description should be updated to follow the repository's template by adding "Notes for the reviewer" and "How to test" sections. For a documentation change, the "How to test" section could include instructions for verifying the documentation renders correctly and that code examples are functional. The PR-Codex content can be retained alongside these template sections to provide additional context.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[Docs] Add guide for using ConnectButton with wagmi application" clearly and concisely summarizes the main change in the changeset. The documentation expansion focuses on providing guidance for integrating ConnectButton/ConnectEmbed with wagmi applications using the inAppWalletConnector, which is accurately captured in the title. The title is specific, avoids vague terminology, and a teammate reviewing the PR history would immediately understand this is a documentation addition about wagmi integration.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _Docs_Add_guide_for_using_ConnectButton_with_wagmi_application

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@joaquim-verges joaquim-verges force-pushed the _Docs_Add_guide_for_using_ConnectButton_with_wagmi_application branch from aff0a46 to 1586f15 Compare October 22, 2025 18:09
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 22, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 22, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2025 18:09 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review October 22, 2025 22:31
@joaquim-verges joaquim-verges requested review from a team as code owners October 22, 2025 22:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/portal/src/app/wallets/adapters/page.mdx (2)

66-101: Documentation structure and integration example are clear and well-explained.

The new section effectively explains the ConnectButton/ConnectEmbed integration pattern, includes a proper code example showing connector lookup and connection via onConnect callback, and provides important guidance about provider wrapping and automatic reconnect behavior. The progression from basic to headless usage is logical.

One minor style issue: Line 68 should use "etc." with a period.

Apply this diff to fix the punctuation:

-You can use the thirdweb react connection components and hooks like ConnectButton, ConnectEmbed, useConnectModal, etc, but still keep using wagmi for the rest of the application.
+You can use the thirdweb react connection components and hooks like ConnectButton, ConnectEmbed, useConnectModal, etc., but still keep using wagmi for the rest of the application.

123-123: Capitalize "React" and consider removing wordiness.

Line 123 has two minor style issues: "react" should be capitalized as "React" (proper noun), and "all of the react components" reads better as "all the react components" for conciseness.

Apply this diff:

-You can also use the thirdweb SDK within a wagmi application by setting the wagmi connected account as the thirdweb 'active wallet'. After that, you can use all of the react components and hooks normally, including `BuyWidget`, `TransactionButton`, etc.
+You can also use the thirdweb SDK within a wagmi application by setting the wagmi connected account as the thirdweb 'active wallet'. After that, you can use all the React components and hooks normally, including `BuyWidget`, `TransactionButton`, etc.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6a7b556 and 1586f15.

📒 Files selected for processing (1)
  • apps/portal/src/app/wallets/adapters/page.mdx (2 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/portal/src/app/wallets/adapters/page.mdx

[style] ~68-~68: In American English, abbreviations like “etc.” require a period.
Context: ...tButton, ConnectEmbed, useConnectModal, etc, but still keep using wagmi for the res...

(ETC_PERIOD)


[style] ~123-~123: Consider removing “of” to be more concise
Context: ...active wallet'. After that, you can use all of the react components and hooks normally, in...

(ALL_OF_THE)


[uncategorized] ~123-~123: “React” is a proper noun and needs to be capitalized.
Context: ...et'. After that, you can use all of the react components and hooks normally, includin...

(A_GOOGLE)

🔇 Additional comments (1)
apps/portal/src/app/wallets/adapters/page.mdx (1)

106-118: Headless connector example is correct and well-demonstrated.

The updated code example properly shows direct inAppWallet connector usage with an explicit strategy parameter. The pattern is consistent with the ConnectButton example and demonstrates proper integration.

@joaquim-verges joaquim-verges merged commit 5828b9b into main Oct 22, 2025
25 checks passed
@joaquim-verges joaquim-verges deleted the _Docs_Add_guide_for_using_ConnectButton_with_wagmi_application branch October 22, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant