Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 22, 2025


PR-Codex overview

This PR introduces support for EIP-5792 in the thirdweb wallet implementation, enhancing the EIP1193.toProvider() functionality. It adds new transaction handling methods and integrates sendCalls and getCallsStatus features for improved wallet interactions.

Detailed summary

  • Added EIP-5792 support for EIP1193.toProvider().
  • Enhanced inAppWalletSendCalls to include chain in transaction options.
  • Updated wagmi.ts to initialize inAppWallet with EIP7702 execution mode.
  • Integrated useSendCalls and useCallsStatus hooks in App.tsx.
  • Modified transaction methods to support multiple new EIP-5792 functionalities in to-eip1193.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

🦋 Changeset detected

Latest commit: 646fdec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 23, 2025 0:47am
nebula Ready Ready Preview Comment Oct 23, 2025 0:47am
thirdweb_playground Ready Ready Preview Comment Oct 23, 2025 0:47am
thirdweb-www Ready Ready Preview Comment Oct 23, 2025 0:47am
wallet-ui Ready Ready Preview Comment Oct 23, 2025 0:47am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Oct 22, 2025
Copy link
Member Author

joaquim-verges commented Oct 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Add EIP-5792 support for wallet_sendCalls and wallet_getCallsStatus [SDK] Add EIP-5792 support for EIP1193.toProvider() Oct 22, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review October 22, 2025 21:25
@joaquim-verges joaquim-verges requested review from a team as code owners October 22, 2025 21:25
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Add_EIP-5792_support_for_wallet_sendCalls_and_wallet_getCallsStatus

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 44.44444% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.87%. Comparing base (6a7b556) to head (646fdec).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/thirdweb/src/adapters/eip1193/to-eip1193.ts 45.90% 66 Missing ⚠️
packages/thirdweb/src/wallets/smart/index.ts 0.00% 2 Missing ⚠️
...src/wallets/in-app/core/eip7702/minimal-account.ts 0.00% 1 Missing ⚠️
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8298      +/-   ##
==========================================
- Coverage   54.90%   54.87%   -0.04%     
==========================================
  Files         919      919              
  Lines       60665    60707      +42     
  Branches     4129     4125       -4     
==========================================
  Hits        33310    33310              
- Misses      27254    27296      +42     
  Partials      101      101              
Flag Coverage Δ
packages 54.87% <44.44%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
...src/wallets/in-app/core/eip7702/minimal-account.ts 88.87% <0.00%> (-0.11%) ⬇️
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 40.16% <0.00%> (-0.17%) ⬇️
packages/thirdweb/src/wallets/smart/index.ts 52.52% <0.00%> (-0.20%) ⬇️
...ckages/thirdweb/src/adapters/eip1193/to-eip1193.ts 54.05% <45.90%> (-17.77%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.55 KB (0%) 1.3 s (0%) 174 ms (+124.55% 🔺) 1.5 s
thirdweb (cjs) 365.82 KB (0%) 7.4 s (0%) 797 ms (+11.92% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 109 ms (+2622.5% 🔺) 224 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 113 ms (+5994.06% 🔺) 124 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 110 ms (+2592.35% 🔺) 491 ms

@joaquim-verges joaquim-verges force-pushed the Add_EIP-5792_support_for_wallet_sendCalls_and_wallet_getCallsStatus branch from 462f0e8 to 646fdec Compare October 22, 2025 22:41
Base automatically changed from _Docs_Add_guide_for_using_ConnectButton_with_wagmi_application to main October 22, 2025 22:42
@joaquim-verges joaquim-verges merged commit 899051f into main Oct 22, 2025
17 of 22 checks passed
@joaquim-verges joaquim-verges deleted the Add_EIP-5792_support_for_wallet_sendCalls_and_wallet_getCallsStatus branch October 22, 2025 22:54
@joaquim-verges joaquim-verges mentioned this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant