Dashboard: /pay/<id> page UI improvements, SDK: CheckoutWidget minor UI tweaks #8310
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "thirdweb": patch | ||
| --- | ||
|
|
||
| Minor UI adjustments in CheckoutWidget |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| "use client"; | ||
| import { Img } from "@workspace/ui/components/img"; | ||
| import { MoonIcon, SunIcon } from "lucide-react"; | ||
| import { useTheme } from "next-themes"; | ||
| import { ClientOnly } from "@/components/blocks/client-only"; | ||
| import { Button } from "@/components/ui/button"; | ||
| import { Skeleton } from "@/components/ui/skeleton"; | ||
| import { cn } from "@/lib/utils"; | ||
| import { resolveSchemeWithErrorHandler } from "@/utils/resolveSchemeWithErrorHandler"; | ||
| import { payAppThirdwebClient } from "../constants"; | ||
|
|
||
| export function PayIdPageHeader(props: { | ||
| projectName: string; | ||
| projectIcon: string | undefined; | ||
| }) { | ||
| return ( | ||
| <div className="border-b border-border/70"> | ||
| <header className="container flex max-w-7xl justify-between py-4"> | ||
| <div className="flex items-center gap-3"> | ||
| {props.projectIcon && ( | ||
| <Img | ||
| src={ | ||
| resolveSchemeWithErrorHandler({ | ||
| uri: props.projectIcon, | ||
| client: payAppThirdwebClient, | ||
| }) || "" | ||
| } | ||
| alt="" | ||
| className="rounded-full size-6 object-cover" | ||
| /> | ||
| )} | ||
|
|
||
| <h2 className="text-xl font-semibold tracking-tight"> | ||
| {props.projectName} | ||
| </h2> | ||
| </div> | ||
|
|
||
| <div className="flex items-center gap-3 lg:gap-5"> | ||
| <ToggleThemeButton /> | ||
| </div> | ||
| </header> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| function ToggleThemeButton(props: { className?: string }) { | ||
| const { setTheme, theme } = useTheme(); | ||
|
|
||
| return ( | ||
| <ClientOnly | ||
| ssr={<Skeleton className="size-[36px] rounded-full border bg-accent" />} | ||
| > | ||
| <Button | ||
| aria-label="Toggle theme" | ||
| className={cn( | ||
| "h-auto w-auto rounded-full p-2 text-muted-foreground hover:text-foreground", | ||
| props.className, | ||
| )} | ||
| onClick={() => { | ||
| setTheme(theme === "dark" ? "light" : "dark"); | ||
| }} | ||
| variant="ghost" | ||
| > | ||
| {theme === "light" ? ( | ||
| <SunIcon className="size-5 " /> | ||
| ) : ( | ||
| <MoonIcon className="size-5 " /> | ||
| )} | ||
| </Button> | ||
| </ClientOnly> | ||
| ); | ||
| } | ||
|
Comment on lines
+46
to
+72
There was a problem hiding this comment. 🛠️ Refactor suggestion | 🟠 Major Code duplication - reuse existing ToggleThemeButton. This ToggleThemeButton implementation duplicates the existing component at Consider importing and reusing the existing component: +import { ToggleThemeButton } from "@/components/blocks/color-mode-toggle";
+
export function PayIdPageHeader(props: {
projectName: string;
projectIcon: string | undefined;
}) {
return (
<div className="border-b border-border/70">
<header className="container flex max-w-7xl justify-between py-4">
<div className="flex items-center gap-3">
{props.projectIcon && (
<Img
src={
resolveSchemeWithErrorHandler({
uri: props.projectIcon,
client: payAppThirdwebClient,
}) || ""
}
alt=""
className="rounded-full size-6 object-cover"
/>
)}
<h2 className="text-xl font-semibold tracking-tight">
{props.projectName}
</h2>
</div>
<div className="flex items-center gap-3 lg:gap-5">
- <ToggleThemeButton />
+ <ToggleThemeButton className="h-auto w-auto p-2 text-muted-foreground hover:text-foreground" />
</div>
</header>
</div>
);
}
-
-function ToggleThemeButton(props: { className?: string }) {
- const { setTheme, theme } = useTheme();
-
- return (
- <ClientOnly
- ssr={<Skeleton className="size-[36px] rounded-full border bg-accent" />}
- >
- <Button
- aria-label="Toggle theme"
- className={cn(
- "h-auto w-auto rounded-full p-2 text-muted-foreground hover:text-foreground",
- props.className,
- )}
- onClick={() => {
- setTheme(theme === "dark" ? "light" : "dark");
- }}
- variant="ghost"
- >
- {theme === "light" ? (
- <SunIcon className="size-5 " />
- ) : (
- <MoonIcon className="size-5 " />
- )}
- </Button>
- </ClientOnly>
- );
-}If styling differences are needed, extend the existing component to accept additional props rather than duplicating the implementation.
🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Add explicit return types.
Per coding guidelines, all function declarations should have explicit return types.
As per coding guidelines
Apply this diff:
Also applies to: 46-46
🤖 Prompt for AI Agents