Version Packages #8336
Version Packages #8336
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughRemoves one .changeset entry and performs version bumps and changelog additions for packages: thirdweb (5.110.6), wagmi-adapter (0.2.174), nebula (0.2.77), nexus (0.1.0), and apps/wagmi-demo (0.0.19); changes are release metadata only. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/package.json (1)
1-59: Consider adding bundle size tracking for the published package.As a published package in the
packages/directory,@thirdweb-dev/wagmi-adapterwould benefit from bundle budget tracking viasize-limitconfiguration in package.json. This helps prevent unexpected increases in package size across releases.For reference, the
size-limitconfiguration pattern:"size-limit": [ { "path": "dist/esm/exports/thirdweb.js", "limit": "XXXKB" } ]Verify whether this was previously configured and should be retained or added.
packages/thirdweb/CHANGELOG.md (1)
3-8: Versions are in sync; consider clarifying the changelog message.The version verification passed—package.json (5.110.6) matches the CHANGELOG.md entry. However, "Update implementations" is vague for readers. If this patch has no user-visible/API impact, call that out explicitly; otherwise, briefly name the affected area (modules, components, etc.) for discoverability.
Suggested revision:
- - [#8334](https://github.com/thirdweb-dev/js/pull/8334) [`6c318f8`](https://github.com/thirdweb-dev/js/commit/6c318f83d63aa8acce46da666e43638e410f799c) Thanks [@kumaryash90](https://github.com/kumaryash90)! - Update implementations + - [#8334](https://github.com/thirdweb-dev/js/pull/8334) [`6c318f8`](https://github.com/thirdweb-dev/js/commit/6c318f83d63aa8acce46da666e43638e410f799c) Thanks [@kumaryash90](https://github.com/kumaryash90)! - Internal implementation updates; no public API or behavior changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/hot-pets-tie.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/hot-pets-tie.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.jsonapps/wagmi-demo/package.jsonpackages/nebula/package.jsonpackages/wagmi-adapter/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/thirdweb/package.jsonapps/wagmi-demo/CHANGELOG.mdpackages/nebula/CHANGELOG.mdpackages/thirdweb/CHANGELOG.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
Applied to files:
packages/thirdweb/package.jsonpackages/nebula/package.jsonpackages/wagmi-adapter/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/thirdweb/package.jsonpackages/nebula/package.jsonpackages/wagmi-adapter/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
apps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (8)
apps/wagmi-demo/package.json (2)
2-4: Version bump is correct but verify package name.The version bump to 0.0.19 matches the PR objectives for the patch release. However, the package name is "wagmi-inapp" (Line 2) while the file is located in
apps/wagmi-demo/. Please confirm this naming is intentional.
14-22: Dependency specifications look good.Workspace references and pinned external dependency versions are appropriate for release stability. The use of
"latest"for@wagmi/cliis acceptable for CLI tooling but please verify this matches the repository's versioning practices.packages/wagmi-adapter/package.json (1)
59-59: Version bump is correct and peer dependencies are compatible.The patch version bump to 0.2.174 matches the PR release plan. Peer dependency constraints (thirdweb@^5.85.0, @wagmi/core@^2.16.0) will accept the updated transitive dependencies (thirdweb@5.110.6) without requiring a change.
packages/nebula/package.json (1)
60-60: Version bump is correctly applied.Patch version increment from 0.2.76 to 0.2.77 aligns with the Changesets release workflow and the dependency update to thirdweb@5.110.6 documented in the CHANGELOG.
packages/thirdweb/package.json (1)
433-433: Version bump is correctly applied.Patch version increment from 5.110.5 to 5.110.6 is appropriate for the implementation-level updates noted in the PR objectives. No changes to the public exports surface detected.
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry is properly formatted and consistent.The 0.2.77 patch entry correctly documents the thirdweb@5.110.6 dependency update and follows the established Changesets convention used throughout the file.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry is properly formatted with correct dependency updates.The 0.0.19 patch entry correctly documents both dependency updates (thirdweb@5.110.6 and @thirdweb-dev/wagmi-adapter@0.2.174) and follows Changesets conventions. The commit reference matches other changelog entries in this PR.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Version header correctly added with no changelog content.The 0.2.174 header-only entry aligns with the PR objectives ("no additional notes") and follows the established pattern in the file where intermediate versions without direct code changes receive header-only entries. Version matches packages/wagmi-adapter/package.json bump.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8336 +/- ##
==========================================
- Coverage 54.90% 54.89% -0.01%
==========================================
Files 920 920
Lines 60715 60715
Branches 4130 4129 -1
==========================================
- Hits 33336 33331 -5
- Misses 27278 27282 +4
- Partials 101 102 +1
🚀 New features to boost your workflow:
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
aa105ad to
f86306f
Compare
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
f86306f to
8afda63
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (2)
11-11: Capitalize ERC20 and tighten phrasingSuggest: capitalize “ERC20” and drop “useful” for consistency with prior entries.
- - [#8332](.../pull/8332) [`8e357b3`](.../commit/8e357b3...) Thanks [@jnsdls]! - expose some useful erc20 extensions + - [#8332](.../pull/8332) [`8e357b3`](.../commit/8e357b3...) Thanks [@jnsdls]! - Expose some ERC20 extensionsIf possible, also list the specific extensions exposed (e.g., names/functions) to aid consumers.
7-7: Clarify “Update implementations”This is vague to readers. Add 2–5 words of scope (e.g., “Update chain implementations,” “Update ERC7702 helpers,” etc.) or reference the affected module(s).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (11)
.changeset/hot-pets-tie.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/nexus/CHANGELOG.md(1 hunks)packages/nexus/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/hot-pets-tie.md
✅ Files skipped from review due to trivial changes (3)
- packages/nexus/CHANGELOG.md
- packages/wagmi-adapter/package.json
- packages/nexus/package.json
🚧 Files skipped from review as they are similar to previous changes (6)
- packages/nebula/package.json
- packages/thirdweb/package.json
- apps/wagmi-demo/CHANGELOG.md
- packages/nebula/CHANGELOG.md
- apps/wagmi-demo/package.json
- packages/wagmi-adapter/CHANGELOG.md
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/thirdweb/CHANGELOG.md (2)
3-11: Semver check: is “Expose ERC20 extensions” a public API addition?If this adds new exports to the
thirdwebpackage, it may qualify as a minor bump per your versioning rules; confirm that it’s truly patch-only (no new public surface), or consider bumping to minor.Based on learnings
9-10: LGTM: devDependency move is appropriateMoving
@storybook/reactto devDependencies is a packaging-only change; good as a patch note.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nexus@0.1.0
Minor Changes
8e357b3Thanks @jnsdls! - initial release@thirdweb-dev/nebula@0.2.77
Patch Changes
6c318f8,759b93b,8e357b3]:thirdweb@5.110.6
Patch Changes
#8334
6c318f8Thanks @kumaryash90! - Update implementations#8306
759b93bThanks @alecananian! - Moved@storybook/reactpackage to be a dev dependency#8332
8e357b3Thanks @jnsdls! - expose some useful erc20 extensions@thirdweb-dev/wagmi-adapter@0.2.174
wagmi-inapp@0.0.19
Patch Changes
6c318f8,759b93b,8e357b3]:PR-Codex overview
This PR focuses on updating package versions and changelogs across several packages, including
thirdweb,nexus, andwagmi-adapter, along with the removal of outdated changeset files.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.110.5to5.110.6.versioninapps/wagmi-demo/package.jsonfrom0.0.18to0.0.19.versioninpackages/nexus/package.jsonfrom0.0.0to0.1.0.versioninpackages/nebula/package.jsonfrom0.2.76to0.2.77.versioninpackages/wagmi-adapter/package.jsonfrom0.2.173to0.2.174.packages/nexusversion0.1.0.packages/nebulaversion0.2.77.apps/wagmi-demoversion0.0.19.packages/thirdwebversion5.110.6.Summary by CodeRabbit
New Features
Bug Fixes
Chores