-
Notifications
You must be signed in to change notification settings - Fork 616
Version Packages #8355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8355
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis pull request coordinates version bumps and changelog updates across multiple packages. The main fix addresses the hiddenWallets prop not applying to the all wallets screen. Version increments: thirdweb@5.111.0→5.111.1, wagmi-adapter@0.2.175→0.2.176, nebula@0.2.78→0.2.79, and wagmi-demo@0.0.20→0.0.21. A changeset file is removed as part of release finalization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog entry lacks details.Version 0.2.176 header is added but contains no Patch Changes section, unlike the updated entries in nebula and wagmi-demo changelogs. While this follows a pattern of many version entries in this file being undocumented, consider adding "### Patch Changes" details for consistency with other updated changelogs, documenting the coordinated patch release.
packages/thirdweb/CHANGELOG.md (1)
3-8: Nit: format prop and screen name for consistency.Elsewhere in this changelog, props are wrapped in backticks and “All Wallets” is title-cased. Suggest:
- - [#8354](https://github.com/thirdweb-dev/js/pull/8354) [`ccdce49`](https://github.com/thirdweb-dev/js/commit/ccdce496e09bc9420b0e15854328651c01f36279) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Fix hiddenWallets prop not applying to all wallets screen + - [#8354](https://github.com/thirdweb-dev/js/pull/8354) [`ccdce49`](https://github.com/thirdweb-dev/js/commit/ccdce496e09bc9420b0e15854328651c01f36279) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Fix `hiddenWallets` prop not applying to the “All Wallets” screen
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/dark-ravens-end.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/dark-ravens-end.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.jsonpackages/wagmi-adapter/package.jsonapps/wagmi-demo/package.jsonpackages/nebula/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (10)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
Applied to files:
packages/thirdweb/package.jsonpackages/wagmi-adapter/package.jsonpackages/nebula/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/thirdweb/package.jsonpackages/wagmi-adapter/package.jsonpackages/nebula/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonapps/wagmi-demo/package.jsonapps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/thirdweb/package.json (1)
433-433: Version bump looks good.Patch version increment (5.111.0 → 5.111.1) is appropriate for the hiddenWallets bug fix. No changes to dependencies or public API.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry is well‑formatted.Version 0.0.21 entry correctly documents dependency updates to thirdweb@5.111.1 and @thirdweb-dev/wagmi-adapter@0.2.176. Format aligns with prior entries.
packages/nebula/package.json (1)
60-60: Version bump is correct.Patch increment (0.2.78 → 0.2.79) is appropriate. Dependencies remain correctly specified as workspace references.
apps/wagmi-demo/package.json (1)
4-4: Version bump is correct.Patch increment (0.0.20 → 0.0.21) is appropriate. Dependencies correctly reference workspace packages.
packages/wagmi-adapter/package.json (1)
59-59: Version bump is correct.Patch increment (0.2.175 → 0.2.176) is appropriate. Peer dependency constraint (^5.85.0) correctly supports thirdweb@5.111.1.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry is properly formatted.Version 0.2.79 entry correctly documents the thirdweb@5.111.1 dependency update with commit reference ccdce49. Format is consistent with prior entries.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8355 +/- ##
==========================================
+ Coverage 54.80% 54.82% +0.01%
==========================================
Files 919 919
Lines 60654 60654
Branches 4111 4116 +5
==========================================
+ Hits 33242 33253 +11
+ Misses 27311 27299 -12
- Partials 101 102 +1
🚀 New features to boost your workflow:
|
size-limit report 📦
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.79
Patch Changes
ccdce49]:thirdweb@5.111.1
Patch Changes
ccdce49Thanks @joaquim-verges! - Fix hiddenWallets prop not applying to all wallets screen@thirdweb-dev/wagmi-adapter@0.2.176
wagmi-inapp@0.0.21
Patch Changes
ccdce49]:PR-Codex overview
This PR focuses on updating version numbers across various packages and their changelogs, reflecting new releases and dependency updates.
Detailed summary
.changeset/dark-ravens-end.md.versioninpackages/thirdweb/package.jsonfrom5.111.0to5.111.1.versioninapps/wagmi-demo/package.jsonfrom0.0.20to0.0.21.versioninpackages/nebula/package.jsonfrom0.2.78to0.2.79.versioninpackages/wagmi-adapter/package.jsonfrom0.2.175to0.2.176.CHANGELOG.mdentries for:packages/nebula: New entry for0.2.79.apps/wagmi-demo: New entry for0.0.21.packages/thirdweb: New entry for5.111.1.Summary by CodeRabbit
Bug Fixes
Chores