Update implementations, fix deployment #8356

kumaryash90 · 2025-11-04T17:05:56Z

PR-Codex overview

This PR focuses on updating the MarketplaceV3 contract addresses in the implementations.ts file and modifying the deployment logic in deploy-published.ts to include a check for the isZkSyncChain utility.

Detailed summary

Updated MarketplaceV3 address from 0xB7387cF425eC8Da1b04b8E34De86245cb32bCA6D to 0x4e0C3577335961Ff800FFDA24981EB2F38D94483.
Updated MarketplaceV3 address from 0xF8fd1016420c2B7832714241d36Efe55D41df126 to 0x12A305cc7168fa3b7B172fE53c57b9a22716F667.
Added check for isZkSyncChain(chain) in the deployment logic to conditionally handle defaultExtensions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Updated MarketplaceV3 contract addresses across ZKSync networks for improved reliability
- Refined deployment behavior to optimize default extensions handling on ZKSync chains
- Addressed deployment inconsistencies to ensure better platform stability

changeset-bot · 2025-11-04T17:06:01Z

🦋 Changeset detected

Latest commit: 1ad7f98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/nebula	Patch
@thirdweb-dev/wagmi-adapter	Patch
wagmi-inapp	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2025-11-04T17:06:06Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

vercel · 2025-11-04T17:06:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs-v2	Ready	Preview	Comment	Nov 4, 2025 5:20pm
nebula	Ready	Preview	Comment	Nov 4, 2025 5:20pm
thirdweb_playground	Ready	Preview	Comment	Nov 4, 2025 5:20pm
thirdweb-www	Ready	Preview	Comment	Nov 4, 2025 5:20pm
wallet-ui	Ready	Preview	Comment	Nov 4, 2025 5:20pm

coderabbitai · 2025-11-04T17:06:15Z

Walkthrough

A patch version update for "thirdweb" with changes to ZKSync deployment configurations. MarketplaceV3 contract addresses are updated for two ZKSync networks. Default extension deployment logic is modified to skip ZKSync chains.

Changes

Cohort / File(s)	Summary
Changeset `.changeset/open-icons-start.md`	New changeset file added marking a patch version update with description "Update implementations, fix deployment"
ZKSync implementations `packages/thirdweb/src/contract/deployment/zksync/implementations.ts`	Updated MarketplaceV3 contract addresses in ZKSYNC_IMPLEMENTATIONS: network 232 address changed to 0x4e0C3577335961Ff800FFDA24981EB2F38D94483, network 37111 address changed to 0x12A305cc7168fa3b7B172fE53c57b9a22716F667
Deployment logic `packages/thirdweb/src/extensions/prebuilts/deploy-published.ts`	Added isZkSyncChain import and updated default extension deployment conditions to skip processing when target chain is ZKSync across two code paths in autoFactory flow

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Address value updates are straightforward but should verify the new addresses are correct for their respective networks
Conditional logic addition for ZKSync chains is minimal but confirm the placement and scope of the checks align with intended deployment behavior

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete. It lacks a properly formatted title, issue tag, notes for reviewers, and testing instructions as specified in the template.	Add a title in format '[SDK/Dashboard/Portal] Feature/Fix: Concise title', include Linear issue tag (TEAM-0000), add reviewer notes section, and specify how to test changes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main changes: updating MarketplaceV3 implementations and fixing deployment logic for ZKSync chains.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch yash/update-implementations-2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4cc6831 and 1ad7f98.

📒 Files selected for processing (3)

.changeset/open-icons-start.md (1 hunks)
packages/thirdweb/src/contract/deployment/zksync/implementations.ts (2 hunks)
packages/thirdweb/src/extensions/prebuilts/deploy-published.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

.changeset/*.md: Each change in packages/* must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API

Files:

.changeset/open-icons-start.md

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from @/types where applicable
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size

Files:

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts
packages/thirdweb/src/contract/deployment/zksync/implementations.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts
packages/thirdweb/src/contract/deployment/zksync/implementations.ts

packages/thirdweb/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

packages/thirdweb/**/*.{ts,tsx}: Every public symbol must have comprehensive TSDoc with at least one compiling @example and a custom tag (@beta, @internal, @experimental, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Lazy‑load heavy dependencies inside async paths (e.g., const { jsPDF } = await import("jspdf"))

Files:

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts
packages/thirdweb/src/contract/deployment/zksync/implementations.ts

🧠 Learnings (4)

📓 Common learnings

Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

📚 Learning: 2025-08-29T15:37:38.513Z

Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API

Applied to files:

.changeset/open-icons-start.md

📚 Learning: 2025-07-18T19:19:55.613Z

Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to src/extensions/** : Auto-generated contracts from ABI definitions in extensions

Applied to files:

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts

📚 Learning: 2025-07-18T19:19:55.613Z

Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Applied to files:

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts
packages/thirdweb/src/contract/deployment/zksync/implementations.ts

🧬 Code graph analysis (1)

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts (1)

packages/thirdweb/src/exports/utils.ts (1)

isZkSyncChain (16-16)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Lint Packages
GitHub Check: Size
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Build Packages
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Analyze (javascript)

🔇 Additional comments (4)

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts (2)

19-19: LGTM!

The import is correctly placed and follows the project's import conventions.

215-236: No changes needed—the code is consistent across files.

The original review comment misses that the call to getAllDefaultConstructorParamsForImplementation at line 226 (previously cited concern about line 248) is inside the guarded if block (line 215). The condition !isZkSyncChain(chain) at line 218 ensures this entire default extensions deployment logic never executes on ZkSync chains. Additionally, getAllDefaultConstructorParamsForImplementation already handles ZkSync with an early return at line 299, preventing any defaultExtensions processing. The PR change is consistent with the existing ZkSync handling pattern in the codebase.

Likely an incorrect or invalid review comment.

.changeset/open-icons-start.md (1)

1-5: LGTM!

The patch version bump is appropriate for configuration updates and deployment bug fixes. The description accurately reflects the changes.

packages/thirdweb/src/contract/deployment/zksync/implementations.ts (1)

1-32: Addresses are properly scoped to configuration; on-chain deployment must be verified manually.

The new MarketplaceV3 addresses (lines 3 and 21) are isolated to this configuration file with no old addresses remaining in the codebase. However, you must manually verify that these contracts are actually deployed and functional at the specified addresses on networks 232 and 37111, as this cannot be confirmed through code inspection alone.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-11-04T17:13:59Z

size-limit report 📦

Path	Size
@thirdweb-dev/nexus (esm)	104.88 KB (0%)
@thirdweb-dev/nexus (cjs)	316.6 KB (0%)

kumaryash90 added 2 commits November 4, 2025 22:34

update implementations

7f23fd1

fix deployment for zk

4073440

kumaryash90 requested review from a team as code owners November 4, 2025 17:05

github-actions bot assigned kumaryash90 Nov 4, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Nov 4, 2025

changeset

1ad7f98

0xFirekeeper approved these changes Nov 4, 2025

View reviewed changes

vercel bot deployed to Preview – wallet-ui November 4, 2025 17:09 View deployment

0xFirekeeper merged commit fd04eef into main Nov 4, 2025
13 of 19 checks passed

0xFirekeeper deleted the yash/update-implementations-2 branch November 4, 2025 17:10

vercel bot deployed to Preview – nebula November 4, 2025 17:10 View deployment

joaquim-verges mentioned this pull request Nov 4, 2025

Version Packages #8357

Merged

vercel bot deployed to Preview – thirdweb_playground November 4, 2025 17:12 View deployment

vercel bot deployed to Preview – thirdweb-www November 4, 2025 17:16 View deployment

vercel bot deployed to Preview – docs-v2 November 4, 2025 17:20 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update implementations, fix deployment #8356

Update implementations, fix deployment #8356

Uh oh!

kumaryash90 commented Nov 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Nov 4, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 4, 2025

Uh oh!

vercel bot commented Nov 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Nov 4, 2025 •

edited

Loading

Review ran into problems

Uh oh!

Uh oh!

github-actions bot commented Nov 4, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update implementations, fix deployment #8356

Update implementations, fix deployment #8356

Uh oh!

Conversation

kumaryash90 commented Nov 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

graphite-app bot commented Nov 4, 2025

How to use the Graphite Merge Queue

Uh oh!

vercel bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Review ran into problems

Uh oh!

Uh oh!

github-actions bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kumaryash90 commented Nov 4, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Nov 4, 2025 •

edited

Loading

vercel bot commented Nov 4, 2025 •

edited

Loading

coderabbitai bot commented Nov 4, 2025 •

edited

Loading

github-actions bot commented Nov 4, 2025 •

edited

Loading