Change TransactionWidget fiat decimals to two

[Yash094]

---

Slack Thread

 

---

PR-Codex overview

This PR focuses on modifying the formatting of token balances in the formatTokenBalance.ts file by changing the maximum number of fraction digits displayed.

Detailed summary

• Changed maximumFractionDigits from 5 to 2 in the currency formatting options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

• Bug Fixes
  • Updated currency formatting to display a maximum of 2 decimal places instead of 5, improving readability and consistency of financial amounts across the app while retaining a minimum precision of 0. This reduces unnecessary fractional detail in displayed balances and price values.

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs-v2	Ready	Preview	Comment	Nov 7, 2025 7:49am
nebula	Ready	Preview	Comment	Nov 7, 2025 7:49am
thirdweb_playground	Ready	Preview	Comment	Nov 7, 2025 7:49am
thirdweb-www	Ready	Preview	Comment	Nov 7, 2025 7:49am
wallet-ui	Ready	Preview	Comment	Nov 7, 2025 7:49am

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3a0aac4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge-queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[coderabbitai]

Walkthrough

Reduced the maximum fraction digits in the formatMoney call from 5 to 2 within the formatTokenBalance module, lowering displayed currency precision while keeping minimum fraction digits at 0.

Changes

Cohort / File(s)	Summary
Currency formatting precision adjustment packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts	Reduced maximumFractionDigits from 5 to 2 in formatMoney, affecting displayed currency precision in ConnectWallet token balances

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the precision change (5 → 2) matches product/design requirements and doesn't lose needed precision for edge cases
• Confirm consistent application across ConnectWallet displays and that UI layout handles the reduced decimal length without visual issues

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately captures the main change: updating TransactionWidget fiat currency formatting to display 2 decimal places instead of 5.
Description check	✅ Passed	The description covers the key aspects: change rationale, implementation details, and testing instructions, though it doesn't follow the suggested title format from the template.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cursor/change-transactionwidget-fiat-decimals-to-two-3c73

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1285d34 and 3a0aac4.

📒 Files selected for processing (1)

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from @/types where applicable
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size

Files:

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts

packages/thirdweb/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

packages/thirdweb/**/*.{ts,tsx}: Every public symbol must have comprehensive TSDoc with at least one compiling @example and a custom tag (@beta, @internal, @experimental, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Lazy‑load heavy dependencies inside async paths (e.g., const { jsPDF } = await import("jspdf"))

Files:

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts

🧠 Learnings (5)

📓 Common learnings

Learnt from: jnsdls
Repo: thirdweb-dev/js PR: 8267
File: packages/thirdweb/src/extensions/erc20/read/getCurrencyMetadata.ts:47-52
Timestamp: 2025-10-16T19:00:34.707Z
Learning: In the thirdweb SDK's getCurrencyMetadata function (packages/thirdweb/src/extensions/erc20/read/getCurrencyMetadata.ts), zero decimals is not a valid value for native currency. If `options.contract.chain.nativeCurrency.decimals` is 0, it should be treated as missing/invalid data and trigger an API fetch to get the correct native currency metadata.

📚 Learning: 2025-06-26T19:46:04.024Z

Learnt from: gregfromstl
Repo: thirdweb-dev/js PR: 7450
File: packages/thirdweb/src/bridge/Webhook.ts:57-81
Timestamp: 2025-06-26T19:46:04.024Z
Learning: In the onramp webhook schema (`packages/thirdweb/src/bridge/Webhook.ts`), the `currencyAmount` field is intentionally typed as `z.number()` while other amount fields use `z.string()` because `currencyAmount` represents fiat currency amounts in decimals (like $10.50), whereas other amount fields represent token amounts in wei (very large integers that benefit from bigint representation). The different naming convention (`currencyAmount` vs `amount`) reflects this intentional distinction.

Applied to files:

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts

📚 Learning: 2025-10-03T23:36:00.631Z

Learnt from: MananTank
Repo: thirdweb-dev/js PR: 8181
File: packages/thirdweb/src/react/web/ui/Bridge/BuyWidget.tsx:27-27
Timestamp: 2025-10-03T23:36:00.631Z
Learning: In packages/thirdweb/src/react/web/ui/Bridge/BuyWidget.tsx, the component intentionally uses a hardcoded English locale (connectLocaleEn) rather than reading from the provider, as BuyWidget is designed to be English-only and does not require internationalization support.

Applied to files:

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts

📚 Learning: 2025-07-18T19:19:55.613Z

Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Applied to files:

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts

📚 Learning: 2025-10-16T19:00:34.707Z

Learnt from: jnsdls
Repo: thirdweb-dev/js PR: 8267
File: packages/thirdweb/src/extensions/erc20/read/getCurrencyMetadata.ts:47-52
Timestamp: 2025-10-16T19:00:34.707Z
Learning: In the thirdweb SDK's getCurrencyMetadata function (packages/thirdweb/src/extensions/erc20/read/getCurrencyMetadata.ts), zero decimals is not a valid value for native currency. If `options.contract.chain.nativeCurrency.decimals` is 0, it should be treated as missing/invalid data and trigger an API fetch to get the correct native currency metadata.

Applied to files:

• packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: Unit Tests
• GitHub Check: E2E Tests (pnpm, esbuild)
• GitHub Check: E2E Tests (pnpm, vite)
• GitHub Check: E2E Tests (pnpm, webpack)
• GitHub Check: Size
• GitHub Check: Lint Packages
• GitHub Check: Build Packages
• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/formatTokenBalance.ts (2)

37-42: LGTM - Fiat currency now displays with standard 2 decimal precision.

The formatCurrencyAmount function now limits fiat amounts to 2 decimal places (down from 5) through the updated formatMoney call, which aligns with standard fiat currency display conventions.

---

44-55: Correct change for fiat currency display.

Reducing maximumFractionDigits from 5 to 2 aligns with standard fiat currency precision (e.g., $10.50). The combination of minimumFractionDigits: 0 and maximumFractionDigits: 2 provides clean, flexible formatting that displays whole numbers without decimals ($10) while capping precision at 2 decimal places ($10.50).

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.63%. Comparing base (7b13015) to head (3a0aac4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...web/ui/ConnectWallet/screens/formatTokenBalance.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8366   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files         919      919           
  Lines       60694    60694           
  Branches     4110     4112    +2     
=======================================
  Hits        33162    33162           
  Misses      27430    27430           
  Partials      102      102           

Flag	Coverage Δ
packages	54.63% <0.00%> (ø)

Files with missing lines	Coverage Δ
...web/ui/ConnectWallet/screens/formatTokenBalance.ts	33.33% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

size-limit report 📦

Path	Size
@thirdweb-dev/nexus (esm)	104.88 KB (0%)
@thirdweb-dev/nexus (cjs)	316.6 KB (0%)

[graphite-app]

Merge activity

• Nov 7, 7:35 AM UTC: jnsdls added this pull request to the Graphite merge queue.
• Nov 7, 7:49 AM UTC: Merged by the Graphite merge queue.