-
Notifications
You must be signed in to change notification settings - Fork 615
Version Packages #8374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8374
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis is a multi-package version release that removes changeset metadata and updates package versions and changelogs across four packages. The thirdweb package is bumped to 5.111.7 with fixes for simulation address handling and a new React hook export, with dependent packages updating accordingly. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
7-9: Polish wording + code formatting for consistency.Capitalize “React” and wrap API names in backticks. Also quote “from” to avoid ambiguity.
Apply this diff to the two bullets:
- Respect from address when simulating with Engine.serverWallet + Respect "from" address when simulating with `Engine.serverWallet` - Expose useInvalidateBalances() react hook + Expose `useInvalidateBalances()` React hook
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
.changeset/clever-horses-turn.md(0 hunks).changeset/curvy-pillows-return.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/clever-horses-turn.md
- .changeset/curvy-pillows-return.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.jsonpackages/wagmi-adapter/package.jsonpackages/nebula/package.jsonapps/wagmi-demo/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
Applied to files:
packages/thirdweb/package.jsonpackages/wagmi-adapter/package.jsonpackages/nebula/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/thirdweb/package.jsonpackages/wagmi-adapter/package.jsonpackages/nebula/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonapps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/CHANGELOG.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.mdpackages/thirdweb/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/thirdweb/package.json (1)
433-433: Version bump looks good.Patch release correctly updated from 5.111.6 to 5.111.7 for the bug fixes and hook export described in the PR.
packages/wagmi-adapter/package.json (1)
59-59: Version bump approved.Patch release correctly updated to 0.2.182 for dependency alignment.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry correctly formatted.New version 0.2.85 entry properly documents the thirdweb dependency update to 5.111.7 as a patch change.
apps/wagmi-demo/package.json (1)
4-4: Version bump approved.Demo app correctly updated to 0.0.27 for dependency alignment.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog entry correctly formatted.Version 0.2.182 header properly placed; empty entry is consistent with this package's release pattern for dependency-only updates.
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry correctly formatted.Version 0.0.27 entry properly documents dependency updates (thirdweb@5.111.7, @thirdweb-dev/wagmi-adapter@0.2.182) as patch changes with correct commit references.
packages/nebula/package.json (1)
60-60: Version bump approved.Patch release correctly updated to 0.2.85 for thirdweb dependency alignment.
| ## 5.111.7 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#8373](https://github.com/thirdweb-dev/js/pull/8373) [`7f08161`](https://github.com/thirdweb-dev/js/commit/7f081618e16e7d5754a09780421e35b244186ce8) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Respect from address when simulating with Engine.serverWallet | ||
|
|
||
| - [#8373](https://github.com/thirdweb-dev/js/pull/8373) [`7f08161`](https://github.com/thirdweb-dev/js/commit/7f081618e16e7d5754a09780421e35b244186ce8) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Expose useInvalidateBalances() react hook | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify the new hook is exported from the public surface.
Ensure useInvalidateBalances is exported via packages/thirdweb/exports/** (and React exports if applicable), and that docs/examples compile.
Run from repo root:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Confirm the symbol exists in source
rg -nP --glob '!**/dist/**' '\buseInvalidateBalances\b' -C2
# 2) Ensure it’s exported from the public exports folder
fd exports -a packages/thirdweb | sed 's#^#DIR: #'
rg -nP '^export\s+\{[^}]*useInvalidateBalances[^}]*\}' packages/thirdweb/exports -C1 || true
rg -nP 'export\s+\*\s+from\s+.*useInvalidateBalances' packages/thirdweb/exports -C1 || true
# 3) If there is a React export surface, check there too
fd exports -a packages/thirdweb/react | sed 's#^#DIR: #'
rg -nP 'useInvalidateBalances' packages/thirdweb/react/exports -C1 || trueLength of output: 3205
---
🏁 Script executed:
```shell
#!/bin/bash
# View the complete implementation of useInvalidateBalances to verify TSDoc
cat packages/thirdweb/src/react/core/hooks/others/useInvalidateBalances.ts
Length of output: 549
TSDoc for useInvalidateBalances is incomplete and missing required custom annotation tags.
The hook is properly exported from packages/thirdweb/src/exports/react.ts and react.native.ts. However, the TSDoc at packages/thirdweb/src/react/core/hooks/others/useInvalidateBalances.ts is missing:
- Custom annotation tags (
@internal,@beta,@experimental) - Return type documentation (should document the returned function's signature:
(params: { chainId?: number }) => void)
Update the JSDoc to include these elements per the codebase standards:
/**
* Invalidate the balances for a given chainId. If no chainId is provided, invalidate all balances.
* @example
* ```ts
* const invalidateBalances = useInvalidateBalances();
* invalidateBalances({ chainId: 1 });
* ```
* @returns A function that invalidates cached wallet balances.
*/Also add the appropriate custom annotation tag (e.g., @public, @beta, etc.) based on the release status.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8374 +/- ##
=======================================
Coverage 54.63% 54.63%
=======================================
Files 919 919
Lines 60694 60694
Branches 4112 4110 -2
=======================================
Hits 33162 33162
Misses 27430 27430
Partials 102 102
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.85
Patch Changes
7f08161,7f08161]:thirdweb@5.111.7
Patch Changes
#8373
7f08161Thanks @joaquim-verges! - Respect from address when simulating with Engine.serverWallet#8373
7f08161Thanks @joaquim-verges! - Expose useInvalidateBalances() react hook@thirdweb-dev/wagmi-adapter@0.2.182
wagmi-inapp@0.0.27
Patch Changes
7f08161,7f08161]:PR-Codex overview
This PR focuses on updating version numbers and changelogs for several packages, including
thirdwebandwagmi-adapter, along with minor dependency updates.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.111.6to5.111.7versioninapps/wagmi-demo/package.jsonfrom0.0.26to0.0.27versioninpackages/nebula/package.jsonfrom0.2.84to0.2.85versioninpackages/wagmi-adapter/package.jsonfrom0.2.181to0.2.182thirdwebandwagmi-demoto reflect updates and new features.Summary by CodeRabbit
New Features
Bug Fixes
Chores