Version Packages #8409
Version Packages #8409
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughMonorepo release: version bumps and changelog entries for thirdweb, wagmi-adapter, nebula, and wagmi-demo; two Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (10)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (3)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog entry lacks details; consider documenting dependency update.The new 0.2.187 header is present but sparse. Compare this to packages/nebula/CHANGELOG.md (lines 5–8), which documents the thirdweb@5.112.1 dependency update with a commit link. If wagmi-adapter's patch is driven by the same underlying commit, consider adding a matching "Patch Changes" section for consistency and clarity. However, if this is intentional (e.g., only transitive updates, no direct changes), this may be acceptable per your changesets workflow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/clear-kiwis-rule.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/clear-kiwis-rule.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (7)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
apps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/package.jsonapps/wagmi-demo/package.jsonpackages/wagmi-adapter/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/wagmi-adapter/package.jsonpackages/nebula/package.jsonpackages/thirdweb/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/wagmi-adapter/package.json (1)
59-59: Version bump aligns with related package updates.Patch version increment is consistent with the monorepo release; dependency constraints (@wagmi/core ^2.16.0, thirdweb ^5.85.0) are sufficiently broad to resolve updated downstream packages.
apps/wagmi-demo/package.json (1)
4-4: Demo app version bump is consistent with dependency updates.Patch release properly reflects updated dependencies (thirdweb@5.112.1, @thirdweb-dev/wagmi-adapter@0.2.187) via workspace:* protocol resolution.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry correctly documents dependency update.The new 0.2.90 entry follows the project's changesets format with a proper commit link to f07b4b5 (PR #8408) and correctly references the thirdweb@5.112.1 dependency upgrade.
packages/thirdweb/package.json (1)
433-433: Core package patch version reflects wallet integration rename.Patch increment (5.112.0 → 5.112.1) is appropriate for the API property rename (otherWallet → allConnectedWallets) in the autoConnect onConnect callback, as documented in PR #8408.
packages/nebula/package.json (1)
60-60: Version bump is consistent with dependency and changelog updates.Patch increment (0.2.89 → 0.2.90) aligns with the workspace:* dependency on thirdweb, which will resolve to 5.112.1, and matches the changelog entry created in the same PR.
packages/thirdweb/CHANGELOG.md (1)
3-8: Clarify back-compat and semver; add a quick migration snippet.
- If
otherWalletwas removed (not aliased), this is a breaking change and should not be under a Patch entry; consider marking as Minor with a BREAKING note.- If it’s backward compatible (alias retained), please state deprecation explicitly and keep Patch.
- Recommend adding a before/after snippet for
autoConnect({ onConnect })to showotherWallet->allConnectedWalletsmigration.Example (adjust if alias exists):
- Rename otherWallet to allConnectedWallets in autoConnect onConnect callback + Rename otherWallet to allConnectedWallets in autoConnect onConnect callback. + If using `otherWallet`, update to `allConnectedWallets`. + (If applicable) `otherWallet` remains as a deprecated alias until removal in v6.apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry is correctly formatted and consistent.The new version 0.0.32 entry follows the standard Changesets format with proper Markdown syntax, correct dependency versions (thirdweb@5.112.1, @thirdweb-dev/wagmi-adapter@0.2.187), and a valid commit reference. The formatting matches all existing entries in the file.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8409 +/- ##
=======================================
Coverage 54.85% 54.85%
=======================================
Files 919 919
Lines 60853 60853
Branches 4142 4142
=======================================
Hits 33378 33378
Misses 27373 27373
Partials 102 102
🚀 New features to boost your workflow:
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
7b0e968 to
f20fc2d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (2)
9-9: Call out the rename impact and add a tiny migration note.Renaming
otherWallettoallConnectedWalletscan break consumers relying on the old param. Suggest adding a one‑liner migration note and (if true) whether an alias or deprecation period exists.Apply this patch to append a brief migration snippet:
- [#8408](https://github.com/thirdweb-dev/js/pull/8408) [`f07b4b5`](https://github.com/thirdweb-dev/js/commit/f07b4b56c5ff82ae69b8a0edb578e4d75a582334) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Rename otherWallet to allConnectedWallets in autoConnect onConnect callback + - Migration: replace `otherWallet` with `allConnectedWallets` in `onConnect` callbacks. + - Before: `autoConnect({ onConnect: ({ otherWallet }) => { /* ... */ } })` + - After: `autoConnect({ onConnect: ({ allConnectedWallets }) => { /* ... */ } })` + - Note: If an alias or deprecation window exists for `otherWallet`, mention it here.
7-7: Clarify scope of “Resolve implementation from contract call.”Briefly specify which proxy patterns this affects (e.g., Transparent, UUPS, Beacon) or the user‑visible effect (fewer manual ABI overrides, more reliable detection) to help readers assess impact.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/clear-kiwis-rule.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/clear-kiwis-rule.md
🚧 Files skipped from review as they are similar to previous changes (6)
- packages/nebula/CHANGELOG.md
- packages/wagmi-adapter/CHANGELOG.md
- packages/wagmi-adapter/package.json
- packages/thirdweb/package.json
- packages/nebula/package.json
- apps/wagmi-demo/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/wagmi-demo/CHANGELOG.md (1)
3-9: Changelog entry is properly formatted and consistent.The new version 0.0.32 entry follows the established format with correct commit links and dependency versions matching the PR objectives (thirdweb@5.112.1 and @thirdweb-dev/wagmi-adapter@0.2.187).
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
f20fc2d to
a96e9c9
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.90
Patch Changes
6cd681c,f07b4b5]:thirdweb@5.112.1
Patch Changes
#8413
6cd681cThanks @kumaryash90! - Resolve implementation from contract call#8408
f07b4b5Thanks @joaquim-verges! - Rename otherWallet to allConnectedWallets in autoConnect onConnect callback@thirdweb-dev/wagmi-adapter@0.2.187
wagmi-inapp@0.0.32
Patch Changes
6cd681c,f07b4b5]:PR-Codex overview
This PR focuses on updating version numbers across multiple packages and changelogs, reflecting dependency updates and improvements in the
thirdweblibrary.Detailed summary
.changeset/clear-kiwis-rule.mdand.changeset/afraid-regions-push.mdversioninpackages/thirdweb/package.jsonfrom5.112.0to5.112.1versioninapps/wagmi-demo/package.jsonfrom0.0.31to0.0.32versioninpackages/nebula/package.jsonfrom0.2.89to0.2.90versioninpackages/wagmi-adapter/package.jsonfrom0.2.186to0.2.187nebula,wagmi-demo, andthirdwebpackages with patch changes reflecting dependency updates tothirdweb@5.112.1and@thirdweb-dev/wagmi-adapter@0.2.187Summary by CodeRabbit
Release Notes
Bug Fixes
Updates