Skip to content

[SDK] Rename otherWallet to allConnectedWallets in autoConnect callback #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

[SDK] Rename otherWallet to allConnectedWallets in autoConnect callback #8408

merged 1 commit into from
Nov 12, 2025
+7 −1

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 12, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on renaming the parameter otherWallet to allConnectedWallets in the autoConnect onConnect callback and updating its type to OnConnectCallback.

Detailed summary

  • Updated the onConnect parameter in AutoConnectProps from (activeWallet: Wallet, allConnectedWallets: Wallet[]) => void to OnConnectCallback.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f07b4b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Nov 12, 2025 10:54pm
nebula Ready Ready Preview Comment Nov 12, 2025 10:54pm
thirdweb_playground Ready Ready Preview Comment Nov 12, 2025 10:54pm
thirdweb-www Ready Ready Preview Comment Nov 12, 2025 10:54pm
wallet-ui Ready Ready Preview Comment Nov 12, 2025 10:54pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _SDK_Rename_otherWallet_to_allConnectedWallets_in_autoConnect_callback

Comment @coderabbitai help to get the list of available commands and usage tips.

@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Nov 12, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges mentioned this pull request Nov 12, 2025
Merged
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Nov 12, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review November 12, 2025 22:22
@joaquim-verges joaquim-verges requested review from a team as code owners November 12, 2025 22:22
@codecov
Copy link

codecov bot commented Nov 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.83%. Comparing base (9442dc7) to head (f07b4b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8408   +/-   ##
=======================================
  Coverage   54.82%   54.83%           
=======================================
  Files         919      919           
  Lines       60844    60844           
  Branches     4136     4134    -2     
=======================================
+ Hits        33359    33364    +5     
+ Misses      27383    27378    -5     
  Partials      102      102
Flag Coverage Δ
packages 54.83% <ø> (+<0.01%) ⬆️
see 2 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025 •
edited
Loading

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 12, 2025 •
edited
Loading

Merge activity

@joaquim-verges
[SDK] Rename otherWallet to allConnectedWallets in autoConnect callba…
f07b4b5 
…ck (#8408)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on renaming the `otherWallet` parameter to `allConnectedWallets` in the `onConnect` callback to improve clarity and consistency in the code.

### Detailed summary
- Updated the `onConnect` callback type in `packages/thirdweb/src/wallets/connection/types.ts` to use `OnConnectCallback`.
- Renamed `otherWallet` to `allConnectedWallets` in the `onConnect` function signature.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the _SDK_Rename_otherWallets_to_allConnectedWallets_in_onConnect_callback branch from f818d2b to 9442dc7 Compare November 12, 2025 22:46
@graphite-app graphite-app bot force-pushed the _SDK_Rename_otherWallet_to_allConnectedWallets_in_autoConnect_callback branch from 7573e4b to f07b4b5 Compare November 12, 2025 22:47
Base automatically changed from _SDK_Rename_otherWallets_to_allConnectedWallets_in_onConnect_callback to main November 12, 2025 22:55
@graphite-app graphite-app bot merged commit f07b4b5 into main Nov 12, 2025
22 checks passed
@graphite-app graphite-app bot deleted the _SDK_Rename_otherWallet_to_allConnectedWallets_in_autoConnect_callback branch November 12, 2025 22:56
@joaquim-verges joaquim-verges mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges