Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 13, 2025

PR-Codex overview

This PR adds a new entry for "Contracts" in the ProjectSidebarLayout component's sidebar, enhancing the navigation options available to users.

Detailed summary

  • Imported ContractIcon from @/icons/ContractIcon.
  • Added a new sidebar item for "Contracts":
    • href: ${props.layoutPath}/contracts
    • icon: ContractIcon
    • label: "Contracts"
  • Removed the previous "Contracts" entry from the sidebar.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Contracts is now a top-level item in the project sidebar for improved navigation and visibility.
    • Contracts entry removed from the Gateway submenu to reduce duplication and streamline the sidebar.

@0xFirekeeper 0xFirekeeper requested review from a team as code owners November 13, 2025 18:23
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

⚠️ No Changeset found

Latest commit: 1a3008b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Nov 13, 2025 6:44pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Nov 13, 2025 6:44pm
nebula Skipped Skipped Nov 13, 2025 6:44pm
thirdweb_playground Skipped Skipped Nov 13, 2025 6:44pm
wallet-ui Skipped Skipped Nov 13, 2025 6:44pm

@0xFirekeeper 0xFirekeeper changed the title [Dashboard] MoveContracts back to top level sidebar [Dashboard] Move Contracts back to top level sidebar Nov 13, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Walkthrough

The Contracts sidebar entry was moved from the Gateway sub-menu to a top-level item in the project sidebar and a ContractIcon import was added; the component signature and exports were unchanged.

Changes

Cohort / File(s) Summary
Sidebar Navigation Restructuring
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx
Added ContractIcon import; promoted Contracts from the Gateway sub-menu to a top-level entry in contentSidebarLinks with an href built from layoutPath; no signature or export changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify ContractIcon import path and availability
  • Confirm Contracts href formatting matches other top-level items
  • Ensure Contracts removed from Gateway sub-menu with no remaining references

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: moving Contracts from a submenu to top-level sidebar navigation.
Description check ✅ Passed The description is mostly complete with detailed summary of changes, but lacks structured sections (Notes, How to test) specified in the template.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch firekeeper/contracts-top-level

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8d22be8 and 1a3008b.

📒 Files selected for processing (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: codecov/project
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel vercel bot temporarily deployed to Preview – nebula November 13, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2025 18:24 Inactive
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.83%. Comparing base (01116bb) to head (1a3008b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8412   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files         919      919           
  Lines       60844    60844           
  Branches     4134     4134           
=======================================
  Hits        33364    33364           
  Misses      27378    27378           
  Partials      102      102           
Flag Coverage Δ
packages 54.83% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula November 13, 2025 18:36 Inactive
@0xFirekeeper 0xFirekeeper merged commit 144bb33 into main Nov 13, 2025
23 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/contracts-top-level branch November 13, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants