[SDK] Better eip5792 handling #8425
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d90a81d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughAdds two changesets; bumps viem and wagmi in the demo; expands demo ConnectButton wallets; refactors capability retrieval to support optional chain filtering; and refactors wagmi-adapter storage to track the active chain under a new key. Changes
Sequence Diagram(s)sequenceDiagram
participant App as App/User
participant Connector as Wagmi Connector
participant Storage as rawStorage
participant Account as Account
rect rgb(235, 245, 230)
Note over Connector,Storage: Reconnect / autoConnect (init)
Connector->>Storage: read "thirdweb:active-chain"
Storage-->>Connector: JSON string (Chain) or empty
Connector->>Connector: parse → lastChain (Chain | undefined)
Connector->>Account: autoConnect(chain = lastChain?.id || smartAccount?.id || 1)
Account-->>Connector: accounts, chain
end
sequenceDiagram
participant DApp as DApp
participant Provider as EIP-1193 Adapter
participant Wallet as Wallet (erc5792)
rect rgb(245, 245, 255)
Note over DApp,Wallet: Capability request with optional chains
DApp->>Provider: request wallet_getCapabilities (params: [account, chains?])
Provider->>Provider: if chains is array → parse first chainId
alt chainId parsed
Provider->>Wallet: account.getCapabilities({ chainId: firstChainId })
Wallet-->>Provider: capabilities for specific chain
else no chainId
Provider->>Wallet: account.getCapabilities({})
Wallet-->>Provider: full capabilities map
end
Provider-->>DApp: normalized capabilities (filtered or full)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
joaquim-verges
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
packages/thirdweb/src/wallets/eip5792/get-capabilities.ts (1)
55-76: LGTM! Consider documenting the chainIdFilter behavior.The refactoring to support chain-specific filtering is well-implemented. The parameter rename to
chainIdFilterand the conditional return logic correctly filter capabilities by chain ID when provided.Note that when
chainIdFilteris specified but doesn't exist in the capabilities map, the result will be{ [chainIdFilter]: undefined }. If this is the intended behavior, consider adding a comment or documenting it.Consider adding JSDoc or a comment to clarify the behavior:
export function toGetCapabilitiesResult( result: Record<string, WalletCapabilities>, + // When provided, returns capabilities for only the specified chainId chainIdFilter?: number, ): GetCapabilitiesResult {packages/thirdweb/src/adapters/eip1193/to-eip1193.ts (1)
167-177: Consider validating the parsed chain ID.The new chain-specific capability retrieval logic correctly handles hex and decimal chain IDs. However, if
chains[0]contains an invalid value,Number(firstChainStr)could produceNaN, which would be truthy but invalid.Consider adding validation:
const chains = request.params[1]; if (chains && Array.isArray(chains)) { const firstChainStr = chains[0]; const firstChainId = isHex(firstChainStr) ? hexToNumber(firstChainStr) : Number(firstChainStr); - return account.getCapabilities( - firstChainId ? { chainId: firstChainId } : {}, - ); + return account.getCapabilities( + firstChainId && !Number.isNaN(firstChainId) + ? { chainId: firstChainId } + : {}, + ); } return account.getCapabilities({});apps/wagmi-demo/src/App.tsx (1)
46-47: Consider removing debug console logs.The console.log statements for capabilities are useful for debugging but may be leftover development code.
If these logs are for debugging purposes, consider removing them:
- console.log("wagmi capabilities", capabilities.error, capabilities.data); - console.log("thirdweb capabilities", thirdwebCapabilities.error, thirdwebCapabilities.data);Alternatively, if this logging is intentional for the demo, consider adding a comment to clarify.
packages/wagmi-adapter/src/connector.ts (2)
55-57: AlignStorageItemwith actual storage usage (optional)
StorageItemstill models"thirdweb:lastChainId", but the implementation has moved to rawlocalStoragewithactiveChainIdKey = "thirdweb:active-chain"and no longer touchesconfig.storage. To avoid confusion, consider either removingStorageItemor updating it to reflect keys you actually read/write via wagmiconfig.storage.-type StorageItem = { - "thirdweb:lastChainId": number; -}; +type StorageItem = Record<string, never>;Also applies to: 61-61
153-153:accountscasts toanytrade away type safety (optional)Both early-return and post-connect paths cast
accountstoany(Lines 153, 201-204). It’s pragmatic, but it bypasses thewithCapabilitiestyping inProperties["connect"]. If you want to keep stronger typing for EIP‑5792 flows, consider tightening these casts to the actual union type or refactoringconnect’s implementation to be generic‑aware; otherwise this is acceptable as a compromise.Also applies to: 201-204
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
.changeset/few-hats-slide.md(1 hunks).changeset/sixty-views-relate.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)apps/wagmi-demo/src/App.tsx(4 hunks)packages/thirdweb/package.json(1 hunks)packages/thirdweb/src/adapters/eip1193/to-eip1193.ts(1 hunks)packages/thirdweb/src/wallets/eip5792/get-capabilities.ts(2 hunks)packages/thirdweb/src/wallets/injected/index.ts(1 hunks)packages/wagmi-adapter/src/connector.ts(7 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: joaquim-verges
Repo: thirdweb-dev/js PR: 7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.
📚 Learning: 2025-08-28T20:50:33.170Z
Learnt from: joaquim-verges
Repo: thirdweb-dev/js PR: 7922
File: apps/playground-web/src/app/ai/ai-sdk/components/chat-container.tsx:167-181
Timestamp: 2025-08-28T20:50:33.170Z
Learning: The SignTransactionInput schema in thirdweb-dev/ai-sdk-provider uses snake_case field names (chain_id) rather than camelCase (chainId).
Applied to files:
packages/thirdweb/src/wallets/injected/index.ts
📚 Learning: 2025-06-03T23:44:40.243Z
Learnt from: joaquim-verges
Repo: thirdweb-dev/js PR: 7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.
Applied to files:
packages/thirdweb/src/wallets/injected/index.tspackages/thirdweb/src/adapters/eip1193/to-eip1193.tsapps/wagmi-demo/src/App.tsxpackages/wagmi-adapter/src/connector.ts
📚 Learning: 2025-06-06T23:46:08.795Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:424-424
Timestamp: 2025-06-06T23:46:08.795Z
Learning: The thirdweb project has an ESLint rule that restricts direct usage of `defineChain`. When it's necessary to use `defineChain` directly, it's acceptable to disable the rule with `// eslint-disable-next-line no-restricted-syntax`.
Applied to files:
packages/wagmi-adapter/src/connector.ts
🧬 Code graph analysis (3)
packages/thirdweb/src/wallets/injected/index.ts (1)
packages/thirdweb/src/wallets/eip5792/get-capabilities.ts (1)
toGetCapabilitiesResult(55-76)
apps/wagmi-demo/src/App.tsx (3)
packages/thirdweb/src/exports/react.native.ts (2)
useActiveAccount(78-78)useCapabilities(87-87)packages/thirdweb/src/exports/react.ts (2)
useActiveAccount(80-80)useCapabilities(89-89)apps/wagmi-demo/src/wagmi.ts (1)
wallet(19-24)
packages/wagmi-adapter/src/connector.ts (1)
apps/wagmi-demo/src/wagmi.ts (2)
wallet(19-24)chain(26-26)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/thirdweb/src/wallets/injected/index.ts (1)
376-394: LGTM!The parameter rename from
chainIdtochainIdFilterimproves clarity and aligns with the updated signature oftoGetCapabilitiesResult. The logic remains unchanged.apps/wagmi-demo/src/App.tsx (1)
73-78: LGTM! Enhanced wallet support.The expanded wallet list now includes MetaMask, Coinbase Wallet, and Rainbow in addition to the in-app wallet, providing users with more connection options in the demo.
apps/wagmi-demo/package.json (1)
20-21: Dependency versions verified as available and compatible.Both viem 2.39.0 and wagmi 2.19.4 exist on the npm registry. wagmi 2.19.4 requires viem 2.x, and 2.39.0 satisfies this constraint. No security advisories were found for either package.
packages/thirdweb/package.json (1)
41-41: viem 2.39.0 is available with no breaking changes or security advisories.The release includes feature additions (sender and nonce properties to getTransaction) and bug fixes (timeout clearing in waitForUserOperationReceipt), along with chain configuration updates. viem@2.39.0 has been released and no security vulnerabilities were found for the package.
packages/wagmi-adapter/src/connector.ts (2)
3-8: Import additions look correct and align with new usageThe added
ChainandThirdwebClienttype imports, plus reuse ofdefineChain/getAddress, are consistent with the rest of this file and the updated active-chain handling. No issues here.
61-61: Persisting fullChainJSON foractiveChainIdKeylooks consistent with new reconnect flowStoring
JSON.stringify(defineChain(chain.id))underactiveChainIdKey(Lines 271-274), combined with the JSON parse intoChaininconnect(Lines 124-128), is a coherent approach for reusing the same chain object across reconnects and switches. Aside from thegetProviderreader inconsistency noted above, this pattern looks solid.Also applies to: 262-275
apps/wagmi-demo/src/App.tsx
Outdated
|
|
||
| function App() { | ||
| const account = useAccount(); | ||
| const twAccount = useActiveAccount(); |
There was a problem hiding this comment.
Remove unused variable.
The twAccount variable is declared but never used in the component.
Apply this diff:
- const twAccount = useActiveAccount();
-📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const twAccount = useActiveAccount(); |
🤖 Prompt for AI Agents
In apps/wagmi-demo/src/App.tsx around line 21, the local constant `twAccount` is
declared via `useActiveAccount()` but never used; remove that unused variable
declaration (or if the hook is needed for side effects, call
`useActiveAccount()` without assigning it) so the code no longer contains an
unused binding.
size-limit report 📦
|
joaquim-verges
force-pushed
the
Update_viem_to_2.39.0_and_wagmi_to_2.19.4
branch
from
26d008f to
d90a81d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8425 +/- ##
=======================================
Coverage 54.83% 54.84%
=======================================
Files 919 919
Lines 60844 60865 +21
Branches 4134 4143 +9
=======================================
+ Hits 33364 33379 +15
- Misses 27378 27384 +6
Partials 102 102
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
packages/wagmi-adapter/src/connector.ts (1)
3-8: Active-chain persistence format is inconsistent betweenswitchChainwriter andgetProviderreaderThe overall direction here (persisting the active chain under
thirdweb:active-chainand using it to drive reconnect/auto-connect) makes sense, and the following look good:
- Using
defineChainandChaintype fromthirdweb(Lines [3-8]) gives a consistent shape for stored chain data.connectnow:
- Accepts a pre-created
walletviaparams.wallet(Line [121]).- Reads
activeChainIdKeyand parses it as aChainJSON payload (Lines [124-129]).- Uses
lastChainIdin both reconnect and first-connect flows (Lines [129], [165-170]).- Returns normalized
accountsviagetAddress(Lines [153], [201-204]).switchChainwrites the active chain asJSON.stringify(defineChain(chain.id))(Lines [271-274]), which matches the JSON-Chainformat thatconnectexpects.However,
getProviderstill treatsactiveChainIdKeyas a plain numeric id:
- Line [220] reads
lastChainIdStrand Line [221] doesNumber(lastChainIdStr), assuming the stored value is a stringified number.- With the new writer (
JSON.stringify(defineChain(chain.id))),Number('{"id":1,...}')isNaN, solastChainIdingetProvideris alwaysundefinedfor data written by the current code.- As a result, the last-chain fallback on Line [223] never actually uses the persisted chain in this path; it silently falls back to
params?.chainId || args.smartAccount?.chain?.id || 1.This is effectively the same mismatch that was flagged previously in an earlier review.
A minimal fix is to align
getProviderwith the JSON-Chainformat used everywhere else and drop the unnecessaryawait:- getProvider: async (params) => { - const lastChainIdStr = await rawStorage?.getItem(activeChainIdKey); - const lastChainId = lastChainIdStr ? Number(lastChainIdStr) : undefined; - const chain = defineChain( - params?.chainId || args.smartAccount?.chain?.id || lastChainId || 1, - ); + getProvider: async (params) => { + const lastChainIdStr = rawStorage?.getItem(activeChainIdKey); + let lastChainId: number | undefined; + if (lastChainIdStr) { + try { + const lastChain = JSON.parse(lastChainIdStr) as Chain; + if (lastChain && typeof lastChain.id === "number") { + lastChainId = lastChain.id; + } + } catch { + // ignore malformed stored value and fall back to defaults + } + } + const chain = defineChain( + params?.chainId || args.smartAccount?.chain?.id || lastChainId || 1, + );This keeps behavior consistent between
connect,getProvider, andswitchChain, and ensures the “autoconnect to last connected chain” story actually works in both connect and provider paths.Also applies to: 61-61, 121-129, 153-153, 201-204, 220-223, 271-274
🧹 Nitpick comments (3)
packages/thirdweb/src/wallets/injected/index.ts (1)
377-383: Chain filter wiring looks correct; add coverage for filtered pathRenaming to
chainIdFilteron Line [377] and threading it intotoGetCapabilitiesResulton Line [383] correctly hook this injected wallet path into the new chain-filtering logic.Given this now changes behavior when
options.chainIdis provided (only returning that chain’s capabilities), consider adding a test that:
- Calls
account.getCapabilities({ chainId })and- Asserts that only the requested chain appears in the result.
This will exercise the new filter plumbing and satisfy the patch coverage warnings.
packages/thirdweb/src/adapters/eip1193/to-eip1193.ts (1)
167-177: Hardenwallet_getCapabilitiesparams access and chain parsingThe new
chainshandling is a good addition, but there are a couple of robustness nits:
- Line [167] assumes
request.paramsis always defined; if a caller omitsparams,request.params[1]will throw before your “wallet does not support” error can be raised.- Lines [170-172] parse the first chain via
Number(firstChainStr)without guarding forNaN. You partially mitigate this by checkingfirstChainIdtruthiness, butNaNis falsy and may be confusing to future readers.You could make this safer and clearer as:
- const chains = request.params[1]; + const chains = request.params?.[1]; if (chains && Array.isArray(chains)) { const firstChainStr = chains[0]; - const firstChainId = isHex(firstChainStr) - ? hexToNumber(firstChainStr) - : Number(firstChainStr); - return account.getCapabilities( - firstChainId ? { chainId: firstChainId } : {}, - ); + const parsed = + typeof firstChainStr === "string" + ? isHex(firstChainStr) + ? hexToNumber(firstChainStr) + : Number(firstChainStr) + : undefined; + const firstChainId = + typeof parsed === "number" && !Number.isNaN(parsed) + ? parsed + : undefined; + return account.getCapabilities( + firstChainId !== undefined ? { chainId: firstChainId } : {}, + ); }This avoids runtime errors on malformed/omitted params while keeping behavior the same for valid calls.
packages/thirdweb/src/wallets/eip5792/get-capabilities.ts (1)
57-57: Avoid returningundefinedcapability entries when filtering by chainThe new
chainIdFilterparameter and conditional on Lines [72-74] correctly introduce per-chain filtering, but there’s a small edge case:
- If
chainIdFilteris provided butresultdoesn’t contain that chain,capabilities[chainIdFilter]isundefined, so you return{ [chainIdFilter]: undefined }(despite theWalletCapabilitiesRecordtype).That’s not a hard bug, but it’s a bit surprising for consumers.
Consider instead:
- return ( - typeof chainIdFilter === "number" - ? { [chainIdFilter]: capabilities[chainIdFilter] } - : capabilities - ) as never; + if (typeof chainIdFilter === "number") { + if (capabilities[chainIdFilter]) { + return { [chainIdFilter]: capabilities[chainIdFilter] } as never; + } + // If the requested chain isn't present, return an empty record + return {} as never; + } + return capabilities as never;And add a unit test that covers:
- Filtering to an existing chain.
- Filtering to a non-existing chain (expects
{}or your preferred empty shape).This makes the API behavior more predictable and addresses the uncovered lines.
Also applies to: 72-74
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
.changeset/few-hats-slide.md(1 hunks).changeset/sixty-views-relate.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)apps/wagmi-demo/src/App.tsx(2 hunks)packages/thirdweb/package.json(1 hunks)packages/thirdweb/src/adapters/eip1193/to-eip1193.ts(1 hunks)packages/thirdweb/src/wallets/eip5792/get-capabilities.ts(2 hunks)packages/thirdweb/src/wallets/injected/index.ts(1 hunks)packages/wagmi-adapter/src/connector.ts(7 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/wagmi-demo/package.json
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: joaquim-verges
Repo: thirdweb-dev/js PR: 7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.
📚 Learning: 2025-08-28T20:50:33.170Z
Learnt from: joaquim-verges
Repo: thirdweb-dev/js PR: 7922
File: apps/playground-web/src/app/ai/ai-sdk/components/chat-container.tsx:167-181
Timestamp: 2025-08-28T20:50:33.170Z
Learning: The SignTransactionInput schema in thirdweb-dev/ai-sdk-provider uses snake_case field names (chain_id) rather than camelCase (chainId).
Applied to files:
packages/thirdweb/src/wallets/injected/index.tspackages/wagmi-adapter/src/connector.ts
📚 Learning: 2025-06-03T23:44:40.243Z
Learnt from: joaquim-verges
Repo: thirdweb-dev/js PR: 7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.
Applied to files:
packages/thirdweb/src/wallets/injected/index.tsapps/wagmi-demo/src/App.tsxpackages/wagmi-adapter/src/connector.tspackages/thirdweb/src/adapters/eip1193/to-eip1193.ts
📚 Learning: 2025-06-06T23:46:08.795Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:424-424
Timestamp: 2025-06-06T23:46:08.795Z
Learning: The thirdweb project has an ESLint rule that restricts direct usage of `defineChain`. When it's necessary to use `defineChain` directly, it's acceptable to disable the rule with `// eslint-disable-next-line no-restricted-syntax`.
Applied to files:
packages/wagmi-adapter/src/connector.ts
🧬 Code graph analysis (3)
packages/thirdweb/src/wallets/injected/index.ts (1)
packages/thirdweb/src/wallets/eip5792/get-capabilities.ts (1)
toGetCapabilitiesResult(55-76)
apps/wagmi-demo/src/App.tsx (1)
apps/wagmi-demo/src/wagmi.ts (1)
wallet(19-24)
packages/wagmi-adapter/src/connector.ts (1)
apps/wagmi-demo/src/wagmi.ts (2)
wallet(19-24)chain(26-26)
🪛 GitHub Check: codecov/patch
packages/thirdweb/src/wallets/injected/index.ts
[warning] 377-377: packages/thirdweb/src/wallets/injected/index.ts#L377
Added line #L377 was not covered by tests
[warning] 383-383: packages/thirdweb/src/wallets/injected/index.ts#L383
Added line #L383 was not covered by tests
packages/thirdweb/src/adapters/eip1193/to-eip1193.ts
[warning] 167-177: packages/thirdweb/src/adapters/eip1193/to-eip1193.ts#L167-L177
Added lines #L167 - L177 were not covered by tests
packages/thirdweb/src/wallets/eip5792/get-capabilities.ts
[warning] 57-57: packages/thirdweb/src/wallets/eip5792/get-capabilities.ts#L57
Added line #L57 was not covered by tests
[warning] 72-74: packages/thirdweb/src/wallets/eip5792/get-capabilities.ts#L72-L74
Added lines #L72 - L74 were not covered by tests
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/thirdweb/package.json (1)
41-41: viem 2.39.0 update confirmed as appropriate.The bump to 2.39.0 includes the EIP-5792 improvements from earlier 2.38.x releases (sendCalls support in 2.38.0 and Trust Wallet fallback in 2.38.1), aligning with the PR's "Better eip5792 handling" objective. 2.39.0 itself adds sender+nonce on getTransaction, a bugfix for the waitForUserOperationReceipt timeout, and new chain entries. The update is stable with no breaking changes.
.changeset/sixty-views-relate.md (1)
1-5: Changeset description matches implementation scopePatch entry for
@thirdweb-dev/wagmi-adapterand its message accurately describe the autoconnect-to-last-chain work in this PR. Nothing to change here..changeset/few-hats-slide.md (1)
1-5: Changeset aligns with EIP-5792 tweaksThe patch entry for
thirdweband its description (“Better handling of erc5792 getCapabilities”) accurately reflect the code changes to capability filtering. No changes needed.apps/wagmi-demo/src/App.tsx (1)
3-3: Demo wallet expansion is consistent with connector APIImporting
createWallet(Line [3]) and extendingConnectButton’swalletsprop (Lines [62-67]) to include MetaMask, Coinbase, and Rainbow lines up with theConnectionOptionsbranch that accepts awalletinstance. The existingonConnecthandler will correctly pass whichever wallet was selected into the in-app connector.Looks good as-is.
Also applies to: 62-67
PR-Codex overview
This PR focuses on improving the handling of wallet capabilities and connection features in the
thirdwebandwagmilibraries, along with updating dependencies for better functionality and compatibility.Detailed summary
erc5792capabilities in thegetCapabilitiesfunction.wagmiadapter.viemversion from2.37.9to2.39.0in multiple packages.wagmiversion from2.17.5to2.19.4.ConnectButtonconfiguration.chainIdFilterinstead ofchainId.toGetCapabilitiesResultto improve capability return structure.Summary by CodeRabbit