-
Notifications
You must be signed in to change notification settings - Fork 620
Version Packages #8426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8426
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis pull request performs a coordinated patch version release across four packages (thirdweb, wagmi-adapter, nebula, and wagmi-demo), bumping versions, documenting changes in changelogs, and removing temporary changeset entries. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes All changes follow a consistent release pattern: version increments and corresponding changelog entries. No logic, structural changes, or behavioral modifications are present. The homogeneous nature of the edits (repetitive version bumps and changelog formatting) requires minimal review complexity. Suggested labels
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/wagmi-demo/package.json (1)
28-28: Consider pinning @wagmi/cli to a specific version.The @wagmi/cli dependency uses "latest", which may cause unpredictable updates. Pinning to a specific version provides better reproducibility and stability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
.changeset/few-hats-slide.md(0 hunks).changeset/sixty-views-relate.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/few-hats-slide.md
- .changeset/sixty-views-relate.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/thirdweb/package.json (1)
433-433: Version bump correctly applied.The patch version increment from 5.112.1 to 5.112.2 is properly formatted and aligns with the documented patch change from PR #8425 (Better handling of erc5792 getCapabilities).
packages/wagmi-adapter/CHANGELOG.md (1)
3-8: Changelog entry properly formatted.The new 0.2.188 entry follows the established changelog format, includes PR and commit references, and clearly describes the improvement to autoconnect handling.
apps/wagmi-demo/CHANGELOG.md (1)
3-10: Dependency updates properly documented.The 0.0.33 changelog entry correctly reflects the bumped dependencies (thirdweb@5.112.2, wagmi-adapter@0.2.188), with matching commit reference and proper formatting.
packages/nebula/package.json (1)
60-60: Version bump correctly applied.The patch version increment from 0.2.90 to 0.2.91 is properly formatted and aligns with the documented patch release from PR #8425 (thirdweb dependency update).
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry properly formatted.The new 0.2.91 entry correctly documents the thirdweb dependency update (5.112.2), with proper formatting and consistent commit reference.
packages/wagmi-adapter/package.json (1)
59-59: Version bump correctly applied.Patch version increment (0.2.187 → 0.2.188) aligns with PR objectives. Peer dependency spec for thirdweb (^5.85.0) accommodates the new 5.112.2 version from this release.
apps/wagmi-demo/package.json (1)
4-4: Version bump correctly applied.Patch version increment (0.0.32 → 0.0.33) aligns with PR objectives. Workspace dependencies (thirdweb, @thirdweb-dev/wagmi-adapter) will auto-resolve to the new bumped versions upon release.
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#8425](https://github.com/thirdweb-dev/js/pull/8425) [`419fb31`](https://github.com/thirdweb-dev/js/commit/419fb3160188c435a89d65caf36bdd845dd239fe) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Better handling of erc5792 getCapabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardize EIP name capitalization.
Use “EIP-5792” (with hyphen/caps) for consistency with the rest of the changelog and the spec naming.
-- Better handling of erc5792 getCapabilities
+- Better handling of EIP-5792 getCapabilities📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [#8425](https://github.com/thirdweb-dev/js/pull/8425) [`419fb31`](https://github.com/thirdweb-dev/js/commit/419fb3160188c435a89d65caf36bdd845dd239fe) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Better handling of erc5792 getCapabilities | |
| - [#8425](https://github.com/thirdweb-dev/js/pull/8425) [`419fb31`](https://github.com/thirdweb-dev/js/commit/419fb3160188c435a89d65caf36bdd845dd239fe) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Better handling of EIP-5792 getCapabilities |
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md around line 7, the entry uses "erc5792" but
the project standardizes EIP names with a hyphen and uppercase; update the text
to use "EIP-5792" (e.g., "Better handling of EIP-5792 getCapabilities") so it
matches the rest of the changelog and spec naming.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8426 +/- ##
==========================================
- Coverage 54.84% 54.83% -0.01%
==========================================
Files 919 919
Lines 60865 60865
Branches 4143 4141 -2
==========================================
- Hits 33379 33373 -6
- Misses 27384 27390 +6
Partials 102 102
🚀 New features to boost your workflow:
|
size-limit report 📦
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.91
Patch Changes
419fb31]:thirdweb@5.112.2
Patch Changes
419fb31Thanks @joaquim-verges! - Better handling of erc5792 getCapabilities@thirdweb-dev/wagmi-adapter@0.2.188
Patch Changes
419fb31Thanks @joaquim-verges! - Better handling of autoconnect to last connected chainwagmi-inapp@0.0.33
Patch Changes
419fb31,419fb31]:PR-Codex overview
This PR focuses on updating the version numbers of several packages and their corresponding changelogs, reflecting dependency updates related to
thirdwebandwagmi-adapter.Detailed summary
versionofthirdwebfrom5.112.1to5.112.2versionofwagmi-inappfrom0.0.32to0.0.33versionofnebulafrom0.2.90to0.2.91versionofwagmi-adapterfrom0.2.187to0.2.188thirdweb,nebula,wagmi-adapter, andwagmi-demoreflecting dependency updates and improvements.Summary by CodeRabbit