Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 18, 2025


PR-Codex overview

This PR focuses on updating the title in the CodeShowcase component and refining the text in the SecretKeySection component for clarity.

Detailed summary

  • Changed the title in CodeShowcase from "POST /v1/auth/initiate" to "POST /v1/transactions".
  • Revised the text in SecretKeySection to clarify that the full secret key should be referenced from the saved key at the time of creation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Corrected punctuation and sentence boundary in a project setup descriptive text to improve clarity.
  • Documentation

    • Updated the API example shown in the getting started/code showcase from the previous endpoint to the current POST /v1/transactions to reflect the intended request path.

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 18, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 18, 2025 16:20 Inactive
@vercel
Copy link

vercel bot commented Nov 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Nov 18, 2025 4:38pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Nov 18, 2025 4:38pm
nebula Skipped Skipped Nov 18, 2025 4:38pm
thirdweb_playground Skipped Skipped Nov 18, 2025 4:38pm
wallet-ui Skipped Skipped Nov 18, 2025 4:38pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 18, 2025 16:20 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula November 18, 2025 16:20 Inactive
@linear
Copy link

linear bot commented Nov 18, 2025

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

⚠️ No Changeset found

Latest commit: 73c924b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

Walkthrough

Two text corrections in the ProjectFTUX dashboard component: the CodeShowcase API endpoint title is updated from "POST /v1/auth/initiate" to "POST /v1/transactions" to match the displayed example, and a grammatical correction is made in SecretKeySection by replacing a comma with a period.

Changes

Cohort / File(s) Summary
ProjectFTUX Component
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx
CodeShowcase title updated from "POST /v1/auth/initiate" to "POST /v1/transactions" to align with actual API example
SecretKeySection Component
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/SecretKeySection.tsx
Grammar correction in descriptive text: comma replaced with period for proper sentence separation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Both changes are simple string/text updates with no logic or state modifications
  • No functional behavior or control flow changes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The linked issue (PRO-112) reports that the curl example uses the transactions API while the title references /auth/initiate. However, the PR changes the title to /v1/transactions, which contradicts the issue's objective to make them consistent by using /auth/initiate. Verify the intended fix: the issue requests the example use /auth/initiate, but the PR changes the title to /v1/transactions instead. Clarify whether the curl example itself uses /auth/initiate or if the scope has changed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The PR description is incomplete. It lacks key template sections: no explicit 'Notes for the reviewer' section and no 'How to test' section with testing instructions. Add 'Notes for the reviewer' and 'How to test' sections to follow the repository template structure and provide clearer testing guidance.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[PRO-112] Dashboard: Project FTUX copy changes' is specific and accurately describes the main changes in the PR: copy updates to Project FTUX components.
Out of Scope Changes check ✅ Passed All changes are in-scope: the PR updates ProjectFTUX.tsx and SecretKeySection.tsx copy as specified in the PR objectives. The SecretKeySection grammatical fix aligns with the objective to clarify wording.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 11-18-_pro-112_dashboard_project_ftux_copy_changes

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 47ec389 and 73c924b.

📒 Files selected for processing (2)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/SecretKeySection.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/SecretKeySection.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@MananTank MananTank marked this pull request as ready for review November 18, 2025 16:20
@MananTank MananTank requested review from a team as code owners November 18, 2025 16:20
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 18, 2025
Copy link
Member Author

MananTank commented Nov 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.83%. Comparing base (2976af3) to head (73c924b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8428   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files         919      919           
  Lines       60865    60865           
  Branches     4141     4141           
=======================================
  Hits        33373    33373           
  Misses      27390    27390           
  Partials      102      102           
Flag Coverage Δ
packages 54.83% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the titles and text in the `ProjectFTUX` components to reflect changes in the API endpoint and improve the clarity of the secret key information.

### Detailed summary
- Changed the `title` in `ProjectFTUX.tsx` from "POST /v1/auth/initiate" to "POST /v1/transactions".
- Updated the text in `SecretKeySection.tsx` to clarify the reference to the full secret key, removing a comma for better readability.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Corrected punctuation in descriptive text within the project setup guide

* **Documentation**
  * Updated API endpoint example in the getting started section

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 11-18-_pro-112_dashboard_project_ftux_copy_changes branch from 47ec389 to 73c924b Compare November 18, 2025 16:30
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 18, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 18, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula November 18, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 18, 2025 16:30 Inactive
@graphite-app graphite-app bot merged commit 73c924b into main Nov 18, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 11-18-_pro-112_dashboard_project_ftux_copy_changes branch November 18, 2025 16:39
@vercel vercel bot temporarily deployed to Production – wallet-ui November 18, 2025 16:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 18, 2025 16:39 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 18, 2025 16:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants