[MNY-336] Portal: Fix spacing issue on menu with link #8560
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
|
WalkthroughMoved the "name" property within the bridge sidebar section object and redistributed padding inside the DocSidebarCategory: padding removed from the Link wrapper and applied to the inner trigger content container to adjust sidebar spacing and clickable area. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
github-actions
bot
added
the
Portal
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8560 +/- ##
=======================================
Coverage 54.49% 54.49%
=======================================
Files 922 922
Lines 61361 61361
Branches 4150 4150
=======================================
Hits 33441 33441
Misses 27818 27818
Partials 102 102
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/src/components/others/Sidebar.tsx (1)
56-243: Consider splitting this sidebar module into smaller components over timeUnrelated to this spacing fix, this file now hosts several components (
DocSidebar,SidebarItem,DocSidebarNonCollapsible,DocSidebarCategory,DocSidebarMobile) plus helpers, which makes it a bit dense for a single-responsibility TSX file. When convenient, consider extracting major pieces (e.g., mobile vs desktop, helpers) into separate modules for easier maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/portal/src/app/bridge/sidebar.tsx(1 hunks)apps/portal/src/components/others/Sidebar.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each TypeScript file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes in TypeScript
Avoidanyandunknownin TypeScript unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.) in TypeScript
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity and testability
Re-use shared types from @/types or local types.ts barrel exports
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics whenever possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic in TypeScript files; avoid restating TypeScript types and signatures in prose
Files:
apps/portal/src/components/others/Sidebar.tsxapps/portal/src/app/bridge/sidebar.tsx
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
apps/portal/src/components/others/Sidebar.tsxapps/portal/src/app/bridge/sidebar.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Lazy-import optional features; avoid top-level side-effects
Files:
apps/portal/src/components/others/Sidebar.tsxapps/portal/src/app/bridge/sidebar.tsx
🧬 Code graph analysis (1)
apps/portal/src/components/others/Sidebar.tsx (1)
packages/thirdweb/src/react/web/ui/components/text.tsx (1)
Link(46-64)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/portal/src/app/bridge/sidebar.tsx (1)
22-80: Guides group name placement looks correct and type-safeSetting
name: "Guides"on the group itself matchesLinkGroup’s shape and ensures the section header renders consistently with other groups; no issues from a typing or behavior perspective.apps/portal/src/components/others/Sidebar.tsx (2)
199-210: Padding move into inner trigger content aligns spacing with itemsMoving the padding to the inner
div(flex gap-2 py-1.5 px-3) keeps the icon/label layout tidy and increases the effective hit area for the category header without changing active/hover text styling; behavior remains consistent.
213-219: Link wrapper update keeps behavior while fixing visual spacingRemoving padding from the
Linkand limiting it toclassName={cn("w-full text-left")}works cleanly with the padded inner div: the visible header area stays fully clickable, while spacing is now controlled in a single place.
size-limit report 📦
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on modifying the sidebar configuration and adjusting styles in the `Sidebar` component for better layout and design.
### Detailed summary
- In `apps/portal/src/app/bridge/sidebar.tsx`:
- Added an entry for `name: "Guides"` in the sidebar configuration.
- In `apps/portal/src/components/others/Sidebar.tsx`:
- Updated the `className` of a `div` to include `py-1.5` and `px-3`.
- Modified the `className` of a `Link` to remove padding classes `py-1.5` and `px-3`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Style**
* Improved sidebar category spacing with enhanced padding distribution
* Expanded interactive click target area for sidebar navigation items
* Better visual organization of the Guides section
<sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
mny-336
branch
from
af5f056 to
f9a4350
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/portal/src/app/bridge/sidebar.tsx (1)
21-80: LGTM! Consider aligning property order across all sections.The Guides section structure is correct and the property reordering doesn't affect functionality. However, for consistency, the "API References" section (lines 82-112) places the
nameproperty at the end (line 111), while both "Guides" and "Resources" place it near the beginning.If desired, apply this diff to align all sections:
{ separator: true }, { + name: "API References", isCollapsible: false, links: [ { href: `/reference`, icon: <EngineIcon />, name: "HTTP API", }, { href: "/references/typescript/v5", icon: <TypeScriptIcon />, name: "TypeScript", }, { href: "/references/typescript/v5", icon: <ReactIcon />, name: "React", }, { href: "/unity", icon: <UnityIcon />, name: "Unity", }, { href: "/unreal-engine", icon: <UnrealEngineIcon />, name: "Unreal Engine", }, ], - name: "API References", },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/portal/src/app/bridge/sidebar.tsx(1 hunks)apps/portal/src/components/others/Sidebar.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/portal/src/components/others/Sidebar.tsx
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each TypeScript file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes in TypeScript
Avoidanyandunknownin TypeScript unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.) in TypeScript
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity and testability
Re-use shared types from @/types or local types.ts barrel exports
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics whenever possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic in TypeScript files; avoid restating TypeScript types and signatures in prose
Files:
apps/portal/src/app/bridge/sidebar.tsx
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
apps/portal/src/app/bridge/sidebar.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Lazy-import optional features; avoid top-level side-effects
Files:
apps/portal/src/app/bridge/sidebar.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
PR-Codex overview
This PR focuses on modifying the sidebar structure and styling in the
sidebar.tsxandSidebar.tsxfiles, enhancing the visual layout and organization of sidebar items.Detailed summary
sidebar.tsx, thename: "Guides"entry was removed.Sidebar.tsx, the padding classes were updated for adivelement to includepy-1.5andpx-3.Linkcomponent's class was modified to remove thepy-1.5andpx-3classes, simplifying its styling.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.