Skip to content

[CLI] Deprecate create#8700

Merged
0xFirekeeper merged 1 commit intomainfrom
firekeeper/create
Mar 5, 2026
Merged

[CLI] Deprecate create#8700
0xFirekeeper merged 1 commit intomainfrom
firekeeper/create

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Mar 5, 2026

PR-Codex overview

This PR focuses on deprecating the thirdweb create CLI command, advising users to switch to the thirdweb dashboard instead.

Detailed summary

  • Added a deprecation notice for the thirdweb create command in packages/thirdweb/src/cli/bin.ts.
  • Informs users to use the thirdweb dashboard at the provided URL.
  • Exits the process with a status of 1 when the create command is invoked.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Deprecations
    • The thirdweb create CLI command has been deprecated and will display a deprecation message when invoked.

@0xFirekeeper 0xFirekeeper requested review from a team as code owners March 5, 2026 19:12
@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-v2 Ready Ready Preview, Comment Mar 5, 2026 7:25pm
nebula Ready Ready Preview, Comment Mar 5, 2026 7:25pm
thirdweb_playground Ready Ready Preview, Comment Mar 5, 2026 7:25pm
thirdweb-www Ready Ready Preview, Comment Mar 5, 2026 7:25pm
wallet-ui Ready Ready Preview, Comment Mar 5, 2026 7:25pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Walkthrough

This pull request adds a deprecation notice for the thirdweb create CLI command. A changeset file documents the patch release, and the CLI binary is updated to print a deprecation message and exit with code 1 when the command is invoked.

Changes

Cohort / File(s) Summary
Release Documentation
.changeset/deprecate-create-command.md
Adds changeset entry documenting the deprecation of the create CLI command as a patch release.
CLI Implementation
packages/thirdweb/src/cli/bin.ts
Adds a case handler for the "create" command that prints a deprecation message and exits with status code 1, following the existing deprecation pattern for other commands.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description provides a clear overview of the changes (deprecating the create command, directing users to dashboard, exiting with status 1), but does not follow the repository's required template structure with sections like Notes for the reviewer and How to test. Consider restructuring the description to match the template format, including sections for Notes for the reviewer and How to test to provide complete context for reviewers.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title '[CLI] Deprecate create' directly and specifically describes the main change—adding a deprecation for the create CLI command, which matches the changeset and code modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch firekeeper/create

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/thirdweb/src/cli/bin.ts (1)

51-52: Remove unreachable break after process.exit(1).

Line 52 is dead code because Line 51 exits the process.

Proposed cleanup
       process.exit(1);
-      break;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/thirdweb/src/cli/bin.ts` around lines 51 - 52, Remove the
unreachable statement following process.exit(1) by deleting the redundant break;
that follows the process.exit(1) call (the break after process.exit(1) within
the same switch/case or control block is dead code and should be removed so only
process.exit(1) remains).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/thirdweb/src/cli/bin.ts`:
- Around line 51-52: Remove the unreachable statement following process.exit(1)
by deleting the redundant break; that follows the process.exit(1) call (the
break after process.exit(1) within the same switch/case or control block is dead
code and should be removed so only process.exit(1) remains).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 28ba6b53-7ea8-429a-a5fe-ba3786a78bbc

📥 Commits

Reviewing files that changed from the base of the PR and between da4a4a5 and d1bc9be.

📒 Files selected for processing (2)
  • .changeset/deprecate-create-command.md
  • packages/thirdweb/src/cli/bin.ts

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.73%. Comparing base (da4a4a5) to head (d1bc9be).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8700   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files         934      934           
  Lines       62968    62968           
  Branches     4138     4135    -3     
=======================================
  Hits        33204    33204           
  Misses      29666    29666           
  Partials       98       98           
Flag Coverage Δ
packages 52.73% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@0xFirekeeper 0xFirekeeper merged commit e13b9a7 into main Mar 5, 2026
26 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/create branch March 5, 2026 19:27
@joaquim-verges joaquim-verges mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant