Skip to content

[CLI] create-stylus fixes#8724

Merged
0xFirekeeper merged 1 commit intomainfrom
firekeeper/styluscli
Mar 26, 2026
Merged

[CLI] create-stylus fixes#8724
0xFirekeeper merged 1 commit intomainfrom
firekeeper/styluscli

Conversation

@0xFirekeeper
Copy link
Copy Markdown
Member

@0xFirekeeper 0xFirekeeper commented Mar 26, 2026


PR-Codex overview

This PR focuses on making improvements to the create-stylus command in the thirdweb CLI by modifying the installation process of cargo-stylus and updating the Rust toolchain version.

Detailed summary

  • Changed the cargo install command to remove the --force flag for cargo-stylus.
  • Updated the Rust toolchain version from 1.87 to stable.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Stylus CLI command installation configuration
    • Updated Rust toolchain setup during project creation

@0xFirekeeper 0xFirekeeper requested review from a team as code owners March 26, 2026 07:58
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: 3135102

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-v2 Ready Ready Preview, Comment Mar 26, 2026 8:11am
nebula Ready Ready Preview, Comment Mar 26, 2026 8:11am
thirdweb_playground Ready Ready Preview, Comment Mar 26, 2026 8:11am
thirdweb-www Ready Ready Preview, Comment Mar 26, 2026 8:11am
wallet-ui Ready Ready Preview, Comment Mar 26, 2026 8:11am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 26, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 47b06abe-a020-4f85-a7b5-15ca3cdc3446

📥 Commits

Reviewing files that changed from the base of the PR and between bef65c8 and 3135102.

📒 Files selected for processing (2)
  • .changeset/funny-cars-end.md
  • packages/thirdweb/src/cli/commands/stylus/create.ts

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

This PR adds a changeset file documenting patch release updates for the thirdweb package and modifies the Stylus CLI create command to remove the --force flag from cargo installation and change the Rust toolchain version from pinned 1.87 to stable.

Changes

Cohort / File(s) Summary
Changeset Documentation
.changeset/funny-cars-end.md
New changeset file declaring patch release with CLI create-stylus command fixes.
Stylus CLI Command Setup
packages/thirdweb/src/cli/commands/stylus/create.ts
Modified Rust toolchain setup: removed --force flag from cargo-stylus installation and changed rustup default from version 1.87 to stable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch firekeeper/styluscli

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xFirekeeper 0xFirekeeper merged commit 32c2ff6 into main Mar 26, 2026
15 of 21 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/styluscli branch March 26, 2026 07:59
@joaquim-verges joaquim-verges mentioned this pull request Mar 26, 2026
Comment on lines +36 to 38
spawnSync("rustup", ["default", "stable"], {
stdio: "inherit",
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rustup default stable command has no error handling. If this command fails (e.g., rustup not installed, network issues), the script will silently continue without setting the correct Rust toolchain, potentially causing subsequent commands to fail with unclear errors.

Should add status check similar to the cargo install command:

const rustupDefault = spawnSync("rustup", ["default", "stable"], {
  stdio: "inherit",
});
if (rustupDefault.status !== 0) {
  spinner.fail("Failed to set Rust toolchain to stable.");
  process.exit(1);
}
Suggested change
spawnSync("rustup", ["default", "stable"], {
stdio: "inherit",
});
const rustupDefault = spawnSync("rustup", ["default", "stable"], {
stdio: "inherit",
});
if (rustupDefault.status !== 0) {
spinner.fail("Failed to set Rust toolchain to stable.");
process.exit(1);
}

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.72%. Comparing base (8e9c51e) to head (3135102).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8724   +/-   ##
=======================================
  Coverage   52.72%   52.72%           
=======================================
  Files         934      934           
  Lines       62968    62968           
  Branches     4135     4135           
=======================================
  Hits        33199    33199           
  Misses      29671    29671           
  Partials       98       98           
Flag Coverage Δ
packages 52.72% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant