Conversation
🦋 Changeset detectedLatest commit: 3135102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
WalkthroughThis PR adds a changeset file documenting patch release updates for the thirdweb package and modifies the Stylus CLI create command to remove the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
| spawnSync("rustup", ["default", "stable"], { | ||
| stdio: "inherit", | ||
| }); |
There was a problem hiding this comment.
The rustup default stable command has no error handling. If this command fails (e.g., rustup not installed, network issues), the script will silently continue without setting the correct Rust toolchain, potentially causing subsequent commands to fail with unclear errors.
Should add status check similar to the cargo install command:
const rustupDefault = spawnSync("rustup", ["default", "stable"], {
stdio: "inherit",
});
if (rustupDefault.status !== 0) {
spinner.fail("Failed to set Rust toolchain to stable.");
process.exit(1);
}| spawnSync("rustup", ["default", "stable"], { | |
| stdio: "inherit", | |
| }); | |
| const rustupDefault = spawnSync("rustup", ["default", "stable"], { | |
| stdio: "inherit", | |
| }); | |
| if (rustupDefault.status !== 0) { | |
| spinner.fail("Failed to set Rust toolchain to stable."); | |
| process.exit(1); | |
| } |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8724 +/- ##
=======================================
Coverage 52.72% 52.72%
=======================================
Files 934 934
Lines 62968 62968
Branches 4135 4135
=======================================
Hits 33199 33199
Misses 29671 29671
Partials 98 98
🚀 New features to boost your workflow:
|
size-limit report 📦
|
PR-Codex overview
This PR focuses on making improvements to the
create-styluscommand in thethirdwebCLI by modifying the installation process ofcargo-stylusand updating the Rust toolchain version.Detailed summary
cargoinstall command to remove the--forceflag forcargo-stylus.1.87tostable.Summary by CodeRabbit