Skip to content

fix: use pnpm version from package.json packageManager field #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eabdelmoneim merged 3 commits into from
Dec 15, 2025
Merged

fix: use pnpm version from package.json packageManager field #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edb11d5
fix: use pnpm version from package.json packageManager field
eabdelmoneim Dec 15, 2025
a0531b6
fix: prevent PHP syntax check from failing on success
eabdelmoneim Dec 15, 2025
7402cb1
fix: upgrade upload-artifact to v4.6.2 for better artifact support
eabdelmoneim Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ jobs:

- name: Setup pnpm
uses: pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b # v2.4.1
with:
version: 8
# Version is automatically read from package.json packageManager field

- name: Get pnpm store directory
id: pnpm-cache
Expand Down Expand Up @@ -65,7 +64,14 @@ jobs:
# Check PHP syntax
if command -v php &> /dev/null; then
echo "Checking PHP syntax..."
find . -name "*.php" -not -path "./vendor/*" -not -path "./node_modules/*" -exec php -l {} \; | grep -v "No syntax errors"
ERRORS=$(find . -name "*.php" -not -path "./vendor/*" -not -path "./node_modules/*" -exec php -l {} \; 2>&1 | grep -v "No syntax errors" || true)
if [ -n "$ERRORS" ]; then
echo "PHP syntax errors found:"
echo "$ERRORS"
exit 1
else
echo "✅ All PHP files have valid syntax"
fi
else
echo "PHP not installed, skipping syntax check"
fi
Expand All @@ -81,7 +87,7 @@ jobs:
echo "- \`build/index.tsx.asset.php\`" >> $GITHUB_STEP_SUMMARY

- name: Upload build artifacts
uses: actions/upload-artifact@c24449f33cd45d4826c6702db7e49f7cdb9b551d # v3.2.1-node20
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: build-artifacts
path: build/
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ jobs:

- name: Setup pnpm
uses: pnpm/action-setup@eae0cfeb286e66ffb5155f1a79b90583a127a68b # v2.4.1
with:
version: 8
# Version is automatically read from package.json packageManager field

- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down