chore: filter functionality for PR and Issue tab#1953
Merged
Conversation
✅ Deploy Preview for next-react-query-tailwind canceled.
|
✅ Deploy Preview for cra-rxjs-styled-components canceled.
|
✅ Deploy Preview for vue3-apollo-quasar ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for angular-apollo-tailwind canceled.
|
✅ Deploy Preview for svelte-kit-scss canceled.
|
✅ Deploy Preview for solidjs-tailwind canceled.
|
✅ Deploy Preview for angular-ngrx-scss canceled.
|
✅ Deploy Preview for remix-gql-tailwind canceled.
|
✅ Deploy Preview for starter-dev-backend canceled.
|
✅ Deploy Preview for nuxt-pinia-tailwind canceled.
|
✅ Deploy Preview for expo-zustand-styled-components canceled.
|
✅ Deploy Preview for qwik-graphql-tailwind canceled.
|
✅ Deploy Preview for solidstart-tanstackquery-tailwind-mod canceled.
|
hdJerry
changed the title
Contributor
|
code looks fine, and the milestone filter works both for issues and prs tab. There is only a little issue: instead of the "loading status" I saw the "no results" component when, for example, I changed the tab from prs to issues, from open to closed, or when I selected a filter and I needed to wait for the API call response. Could you please fix this behavior? @hdJerry |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @hdJerry. 👋 Your PR has been approved and merged. 🎉 Thank you for your continued contributions to the starter.dev GitHub showcases repo. ❤️ Keep up the great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of change
You this includes
Checklist