Skip to content

Conversation

@lindakatcodes
Copy link
Contributor

Type of change

  • Documentation change
  • Bug fix

Summary of change

A few small cleanup tasks from an overall kit review recently.

  • Simplify the README to focus more on specific decisions made
  • Create a separate dev:debug script to run the XState visualizer in
  • Set the cursor to be a pointer on the button components
  • Adjusted the spelling of the kit name in the package.json description to match the other Vue3 kit
  • Enforced the specific node version, to avoid conflict issues between Storybook / Node / Webpack / SSL

Checklist

  • These changes follow the contributing guidelines
  • This starter kit has been approved by the maintainers
  • I have verified the fix works and introduces no further errors

@lindakatcodes lindakatcodes self-assigned this Jun 9, 2023
@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit 977d0aa
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/6483b5b333c68900082289e1

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments but looks good

Also, when I was looking at this locally, this link didn't seem to work.
For more setup options, check out our setup instructions in the wiki.

Can we remove that from the readme and write out the steps?

lindakatcodes and others added 2 commits June 9, 2023 18:03
Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lindakatcodes lindakatcodes merged commit 312ca6d into main Jun 9, 2023
@lindakatcodes lindakatcodes deleted the fix/vue3-xstate-cleanup-issues branch June 9, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants