Merged
Conversation
✅ Deploy Preview for starter-dev canceled.
|
jdwilkin4
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jdwilkin4
commented
Jun 13, 2023
Comment on lines
112
to
113
| console.log('\nNext steps:'); | ||
| console.log(` ${bold(cyan(`cd ${options.name}`))}`); |
Contributor
Author
There was a problem hiding this comment.
I think Dustin wanted to update the language here to be this based on the slack thread disucssion:
oh update next steps to say "npm start" (or equivalent based on package manager selected" instead of "npm install"
I double check with him on that.
Contributor
There was a problem hiding this comment.
When the kit is created we would still be outside of the newly created directory though and would still need to cd into it.
jdwilkin4
commented
Jun 13, 2023
jdwilkin4
commented
Jun 13, 2023
Comment on lines
+21
to
+23
| `cd ${path} && git init && ${packageManager} ${ | ||
| packageManager === 'deno' ? 'cache --lock=deno.lock --lock-write deps.ts' : 'install' | ||
| } && git add . && git commit -m 'init commit generated by starter.dev CLI' && cd ../`, |
Check warning
Code scanning / CodeQL
Shell command built from environment values
|
Kudos, SonarCloud Quality Gate passed!
|
WillHutt
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary of change
Checklist