Fix VNC WebSocket auth: embed token in path param for noVNC#132
Merged
Fix VNC WebSocket auth: embed token in path param for noVNC#132
Conversation
The upstream fix incorrectly removed the token from the noVNC `path` query parameter, expecting noVNC to pass the `token` URL param to the WebSocket connection natively. It doesn't — noVNC only uses the `path` param to build the WebSocket URL. This broke auth on the websockify endpoint. Restore embedding the token inside the `path` param (vnc/websockify?token=...) so it reaches the auth middleware, and delete it from the visible URL to keep it out of browser history. https://claude.ai/code/session_01TMLTZQ9HssUWawScCmeZGT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream fix incorrectly removed the token from the noVNC
pathquery parameter, expecting noVNC to pass thetokenURL param to the WebSocket connection natively. It doesn't — noVNC only uses thepathparam to build the WebSocket URL. This broke auth on the websockify endpoint.Restore embedding the token inside the
pathparam (vnc/websockify?token=...) so it reaches the auth middleware, and delete it from the visible URL to keep it out of browser history.https://claude.ai/code/session_01TMLTZQ9HssUWawScCmeZGT