avoid noise if systemd not running#55
Conversation
|
I agree that if no dbus is running, we should ignore that silently. So the first change is Ok. But I don't agree with the second one: in this case, dbus is running and a real error happened. Cases like systemd is too old are already ignored and don't lead to an error message. But real errors should be logged, so that people see something is broken and can fix it. Else debugging problems will be pretty difficult. |
In that case, how about adding |
cecce5d to
3ad0338
Compare
|
Force-push checks the error code specifically for no systemd. Without: With: |
|
Thanks |
Hi,
If wtmpdb is run without systemd then a message is printed every boot about failing to count soft reboots (also similarly in a minimal system without even dbus).
It seems to me that if this happens then soft reboot counts are irrelevant because they are a systemd concept to begin with so it is sufficient to fail silently.
If the system is broken in some more fundamental way then I think that will not need wtmpdb to be the means by which the user is informed - so I suspect the value of these messages might only be during development.
Debian has carried this patch for 10 months without any issue - would you be prepared to take it or something equivalent/better upstream?
Thanks!