fix: harden API security#12
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…m hardening Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hash_hmackeyed byDEVICE_TOKEN_HASH_SECRET; authenticator auto-upgrades legacy tokens on first use so existing devices are not invalidatedFixedWindowEndpointRateLimiter(pessimistic DB lock,wrapInTransaction) applied to device registration (20/min), fall alert creation (6/min), and invite acceptance (5/10min)random_bytes(16)→ 128-bit hex code (was 32-bit); column widened in migrationMESSENGER_FAILED_TRANSPORT_DSNenv varTRUSTED_PROXIESenv var sogetClientIp()resolves correctly behind Caddy/Nginxassert()with explicitinstanceofchecks in all three state processorsSecurity issues resolved
assert()disabled in prod PHP configTest plan
make lint— 0 changesmake analyse— 0 errorsmake rector— 0 changesmake test— all pass, coverage ≥ 90%make test-behat— all scenarios passDEVICE_TOKEN_HASH_SECRETset in prod deployment secretsMESSENGER_FAILED_TRANSPORT_DSNset in prod deployment secretsTRUSTED_PROXIESmatches actual proxy setup in prod🤖 Generated with Claude Code