Replace pytz with ZoneInfo + misc datetime fixes#13
Merged
thombashi merged 2 commits intothombashi:masterfrom May 9, 2026
Merged
Replace pytz with ZoneInfo + misc datetime fixes#13thombashi merged 2 commits intothombashi:masterfrom
thombashi merged 2 commits intothombashi:masterfrom
Conversation
thombashi
approved these changes
May 9, 2026
Owner
thombashi
left a comment
thombashi
left a comment
There was a problem hiding this comment.
Thank you for your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Big one is using
zoneinfo.ZoneInfoin place ofpytzsince this library is 3.9+. Mostly just.localizeto.replacebut I added a test for the PEP 495 / defaultfold=0behaviour. Technically this is a behaviour change sincepytzdefaults tois_dst=Falsebut this would align more consistently with the current stdlib semantics / PEP 495. Seetest_normal_datetime_dst_ambiguous_default_foldSmaller fixes:
Simplified
__from_timestamp;datetime.fromtimestamp()accepts a float (and preserves microseconds) so we testInteger/RealNumberagainsttimestampand then a singlefromtimestamp(float(...))call. (Adjusted the guards tois not Nonesince technically 0 / 0.0 are valid timestamps 🤷)Simplified
__get_timedelta_sec: Just use thetimedelta.total_seconds(). No behaviour change.