fix: Remove redundant directory creation and use HttpClient from DownloadOptions

[thomhurst]

Summary

• FileSystemModuleEstimatedTimeProvider: Remove duplicate directory creation call
• Downloader: Pass HttpClient from DownloadOptions to HttpOptions

Changes

• FileSystemModuleEstimatedTimeProvider.cs: Remove redundant directoryInfo.Create() call that was already handled by conditional check above
• Downloader.cs: Add HttpClient = options.HttpClient to HttpOptions so custom HttpClient instances are actually used

Test plan

• Build verification passes
• Existing tests continue to pass

Fixes #1588, fixes #1589

🤖 Generated with Claude Code

[thomhurst]

Summary

This PR fixes two bugs: removes a redundant directory creation call and ensures custom HttpClient instances from DownloadOptions are properly passed through to HttpOptions.

Critical Issues

None found ✅

Analysis

Change 1: Downloader.cs (src/ModularPipelines/Context/Downloader.cs:62)

Bug Fix: The DownloadOptions.HttpClient property was not being passed to HttpOptions, meaning custom HttpClient instances were being ignored. This change correctly passes it through, enabling users to provide custom HttpClient configurations (timeouts, handlers, certificates, etc.).

Change 2: FileSystemModuleEstimatedTimeProvider.cs (src/ModularPipelines/Engine/FileSystemModuleEstimatedTimeProvider.cs:30-33)

Code Quality Fix: Removes duplicate directoryInfo.Create() call. The conditional check on lines 28-31 already handles directory creation, making the duplicate call on line 33 redundant.

Both changes are straightforward, focused, and correct.

Verdict

✅ APPROVE - No critical issues

[thomhurst]

Summary

This PR fixes a duplicate directory creation call and passes through the HttpClient option in the Downloader class.

Critical Issues

None found ✅

Suggestions

None - both fixes are straightforward improvements:

1. FileSystemModuleEstimatedTimeProvider.cs:33 - Removes duplicate directoryInfo.Create() call (redundant after line 30)
2. Downloader.cs:63 - Adds missing HttpClient = options.HttpClient property mapping to respect the HttpClient option from DownloadOptions

Verdict

✅ APPROVE - No critical issues