refactor: Convert CodeCovSettings from class to record#1719
Merged
Conversation
Convert CodeCovSettings to a record for consistency with other settings classes (CodacySettings, GitHubSettings, NuGetSettings, PublishSettings). Also adds [SecretValue] attribute to Token property to match the pattern used by other settings that contain sensitive values. Fixes #1546 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
Owner
Author
SummaryAdds [SecretValue] attribute to CodeCov token and converts class to record for consistency. Critical IssuesNone found ✅ SuggestionsNone - the changes align perfectly with existing patterns in the codebase (GitHubSettings, CodacySettings, NuGetSettings all use record with [SecretValue] on token/API key properties). Verdict✅ APPROVE - No critical issues The PR correctly:
|
There was a problem hiding this comment.
Pull request overview
This PR refactors CodeCovSettings from a class to a record for consistency with other settings classes in the build pipeline. It also adds the [SecretValue] attribute to the Token property to ensure proper handling of sensitive data, matching the pattern used in CodacySettings, GitHubSettings, and NuGetSettings.
Key Changes:
- Converted
CodeCovSettingsfromclasstorecord - Added
[SecretValue]attribute to theTokenproperty - Added required
using ModularPipelines.Attributes;directive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeCovSettingsfromclasstorecordfor consistency with other settings[SecretValue]attribute toTokenproperty to match the pattern in other settingsContext
All other settings classes in the build pipeline use
record:CodacySettings- record with[SecretValue]on TokenGitHubSettings- recordNuGetSettings- record with[SecretValue]on ApiKeyPublishSettings- recordCodeCovSettingswas the only one usingclass, creating an inconsistency.Test plan
Fixes #1546
🤖 Generated with Claude Code