Conversation
…n GitHelpers - Add GitUserName, GitUserEmail, RepositoryOwner, and RepositoryName properties to GitHubSettings - Update GitHelpers to use configurable settings instead of hardcoded values - Add default values for backward compatibility (github-actions[bot] for commits) - Update appsettings.json with new configuration options Closes #1494 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
SummaryReplaces hardcoded GitHub credentials (user name, email, repository owner/name) with configurable options in GitHubSettings. Critical IssuesNone found ✅ SuggestionsNone - the implementation is clean and maintains backward compatibility through sensible defaults. Verdict✅ APPROVE - No critical issues The refactoring successfully:
|
There was a problem hiding this comment.
Pull request overview
This PR successfully refactors hardcoded GitHub credentials and repository information into configurable settings, improving the flexibility and reusability of the ModularPipelines build system. The changes replace hardcoded values like "Tom Longhurst" and "thomhurst@users.noreply.github.com" with configurable properties while maintaining backward compatibility through sensible defaults.
Key changes:
- Adds four new configurable properties to
GitHubSettingsfor git user info and repository details - Refactors
GitHelpers.csto consistently use settings instead of hardcoded values - Provides appropriate defaults (
github-actions[bot]for automation, existing repo values for continuity)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ModularPipelines.Build/Settings/GitHubSettings.cs |
Adds four new properties with XML documentation and default values for git user credentials and repository identification |
src/ModularPipelines.Build/GitHelpers.cs |
Refactors all methods to use configurable settings via new GetGitHubSettings helper method instead of hardcoded strings |
src/ModularPipelines.Build/appsettings.json |
Adds configuration entries for the new settings with appropriate default values matching the code |
Summary
GitUserName,GitUserEmail,RepositoryOwner, andRepositoryNameconfigurable properties toGitHubSettingsGitHelpers.csto use these settings instead of hardcoded values like "Tom Longhurst" and "thomhurst@users.noreply.github.com"github-actions[bot]for automated commits) for backward compatibilityappsettings.jsonTest plan
Closes #1494
🤖 Generated with Claude Code