-
-
Notifications
You must be signed in to change notification settings - Fork 110
perf: ThreadSafeDict extract slow logic
#4532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbc6886 to
3fbb5a5
Compare
3fbb5a5 to
159039e
Compare
Owner
SummaryExtracts slow path logic in ThreadSafeDictionary.GetOrAdd to a separate method to prevent eager closure allocation on the fast path. Critical IssuesNone found ✅ SuggestionsNone - this is a clean micro-optimization that avoids unnecessary allocations on the hot path (key exists case) without changing behavior. Verdict✅ APPROVE - No critical issues Review Notes:
|
This was referenced Jan 25, 2026
This was referenced Jan 26, 2026
Closed
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# compiler like to eagerly initialise closures at the start of the method, so even on fast paths the display class for
valueFactorywas being created. Extracting the slow code to a new method solves this issue.I have no idea why the .NET compiler does this, I assume it's a correctness thing (sometimes due
ifelseusage). I really wish it didn't do this.Before
After