fix: force synchronous library module initializer completion

[thomhurst]

Summary

Fixes the timing issue where hooks from library assemblies were collected before their module initializers completed, resulting in 0 hooks being found.

Problem

When using Microsoft.Testing.Platform, module initializers from different assemblies run asynchronously. The sequence was:

1. Test assembly module initializer runs
2. References library types: _ = typeof(LibraryType)
3. Library assembly loads, but module initializer is queued (not executed immediately)
4. Test module initializer completes
5. HookDelegateBuilder.InitializeAsync() runs and collects hooks
6. 0 hooks found because library module initializer hasn't run yet
7. Library module initializer finally runs (too late)
8. Library hooks get registered to Sources.* collections

Debug output showed:

Building global hook delegates...
Built 0 global hook delegates
[ModuleInitializer] TUnit infrastructure initializing...  ← Library's initializer, too late!

Solution

Use RuntimeHelpers.RunClassConstructor(type.TypeHandle) to force library module initializers to complete synchronously. Static constructors can only run AFTER module initializers, so calling this blocks until initialization finishes.

Generated code now:

var type_0 = typeof(global::TUnit.TestProject.Library.AsyncBaseTests);
// Force module initializer to complete before proceeding
// RunClassConstructor triggers static constructor, which can only run AFTER module initializer completes
global::System.Runtime.CompilerServices.RuntimeHelpers.RunClassConstructor(type_0.TypeHandle);
global::TUnit.Core.GlobalContext.Current.GlobalLogger.LogDebug("[ModuleInitializer] Assembly initialized: ...");

✅ AOT Compatible - Uses only statically-known types and AOT-safe RuntimeHelpers API

Changes

InfrastructureGenerator.cs

• Replace _ = typeof(typeName) with RunClassConstructor() for synchronous initialization
• Add logging to show when assembly initialization completes
• Update documentation explaining the fix

claude-code-review.yml

• Enhanced workflow to always post review comments (even when code is good)
• Focus on suggesting architectural improvements, not minor optimizations
• Explain WHY suggestions are better, not just WHAT to change

Snapshot Tests

• Updated verified snapshots for fully qualified type names in generated code
• Added missing ConflictingNamespaceTests snapshots

Test Plan

• Build succeeds
• Source generator produces correct code with RunClassConstructor()
• Snapshot tests updated and pass
• Verify hooks from library assemblies are now found during collection
• Test with the original failing scenario from the issue

Related Issues

Related to the recent fix in #4599 for library assembly hooks not executing.